Skip to content
Snippets Groups Projects

Fix MuonTruthAssociationAlg for running without CSCs

Merged William Axel Leight requested to merge wleight/athena:ATLASRECTS-5920 into master

The algorithm now checks to see if CSC hits are available before retrieving them, which was causing an exception which prevented the link from truth to reco muon being set. This will solve the problem of muon efficiency (as determined by the MuonPerformanceAlg) appearing to be 0 for symmetrical Run-3 layouts, as reported in ATLASRECTS-5920.

Closes ATLASRECTS-5920

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • adea64c9 - Change to using m_idHelperSvc->hasCSC() to check if CSC is being used.

    Compare with previous version

  • William Axel Leight resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • MuonSpectrometer/MuonTruthAlgs

    This merge request affects 1 file:

    • MuonSpectrometer/MuonTruthAlgs/src/MuonTruthAssociationAlg.cxx

    Adding @rosati ,@nkoehler ,@wleight ,@jojungge as watchers

  • CI Result SUCCESS (hash 8e99b3f2)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals
    cmake
    make
    required tests
    optional tests

    Full details available on this CI monitor view
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    AthGeneration: number of compilation errors 0, warnings 0
    AnalysisBase: number of compilation errors 0, warnings 0
    AthAnalysis: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26739]

  • CI Result SUCCESS (hash adea64c9)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals
    cmake
    make
    required tests
    optional tests

    Full details available on this CI monitor view
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    AthGeneration: number of compilation errors 0, warnings 0
    AnalysisBase: number of compilation errors 0, warnings 0
    AthAnalysis: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26743]

  • Thanks @wleight, I just added alsoTargeting:21.3 and alsoTargeting:21.9 since this is missing in 21.3 and 21.9 as well. Don't worry, if the automatic sweep will fail, I will take care of the manual one. Best, Nico

  • mentioned in commit d0e6503e

  • Sweep summary
    failed:

    • 21.3
    • 21.9
  • Nicolas Koehler mentioned in merge request !39997 (merged)

    mentioned in merge request !39997 (merged)

  • automatic sweep into 21.3 and 21.9 failed, manual sweep here: !39997 (merged), thus, removing sweep:failed label

  • Thanks a lot, @nkoehler !

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading