Skip to content
Snippets Groups Projects

Set up a chain with a preselection

Merged Peter Sherwood requested to merge peter/athena:master-22642-0 into master

Preselection is done before sending jets to the FastReducer algorithm. Preselection is performed by using a ConditionFilter attribute of TrigJetHypoToolHelperNoGrouper.

When acting as a preselector the Filter instance is supplied by a sequence of Conditions. The sequence is used to select jets in the veto region. A ConditionInverter object inverts the result, and the Filter acts to veto jets satisifying all the conditions.

In the case dealt with in this merge request, an example chain has been added to the LS2_v1.py menu that species an eta-phi region.mFor this chain, the filter is set up to veto incoming jets that lie in this region.

@jbossios @valentem @khoo @peter

ATR-22642

Edited by Peter Sherwood

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jonathan Bossio
  • Author Developer

    This is a clean up of defaults and scaling being done in > 1 place. Both actions, which involve switching from string to float to string is done in treeVisitors.py.

  • I see, but then shouldn't we have also j1ethi, j2ethi and djmasshi in defaultParameters in treeVisitors.py?

  • Author Developer

    The default is set in the code.

    Placing all defaults in a list is error prone. Short lists can be scanned accurately by eye, but long lists are a great way to hide bugs.

    Here keep a short list by recognising that standard values can be identified, and need not be added to the list.

    In the beginning the list was short, so was ok.

    Of course, there is nothing to say that the current list, short as it is now, will not grow to an unreasonable size in the future - but the growth rate has been lowered...

  • I see now you have a default value for 'missing' default values. It's indeed better this way. Will close the corresponding thread.

  • Jonathan Bossio resolved all threads

    resolved all threads

  • added master label

  • added Trigger label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading