Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 158
    • Merge requests 158
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !40130

[ATR-22104] Trigger Navigation Links - allow for remapping checks to be optional

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tim Martin requested to merge tamartin/athena:decisionObjectLinkFetching into master Jan 29, 2021
  • Overview 21
  • Commits 7
  • Pipelines 6
  • Changes 4

An optimisation as part of trigger navigation slimming and thinning for R3.

As this touches a low level interface, it needs to go in first. The following larger MR will then build on the nightly which includes this change.

At present, each link retrieved from an xAOD::TrigComposite makes a check if there happens to be updated (via dynamic decoration) information to use.

This check requires a SG lock to be briefly enacted.

The check is made a vast number of times when navigating the trigger navigation, whereas it is only needed for links which online originated inside EventViews.

The mayBeRemapped flag is hence only set to true deep in the TDT's features retrieval code when we know that we need to be making the check.

Other changes along for the ride:

  • Inclusion of removeObjectLink & removeObjectCollectionLinks for the slimming code to use.
  • Additional static node name specifiers for the HLT Summary Alg to make use of
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: decisionObjectLinkFetching