Intermediate update of the TRTMonitoringRun3

This is the intermediate functional update of the TRTMonitoringRun3. Optimization and code cleanup will be done shortly after the functional part will be finalized, which is rapidly developing now.

added DQ InnerDetector labels

WARNING: big files (>100K) are found in the changeset

104K in file InnerDetector/InDetMonitoring/TRTMonitoringRun3/src/TRTMonitoringRun3RAW_Alg.cxx

This merge request affects 3 packages:

• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/TRTMonitoringRun3
• Projects/WorkDir

Affected files list will not be printed in this case

Adding @cgrefe ,@calfayan ,@akraszna ,@sroe ,@goetz as watchers

added Build master review-pending-level-1 labels

Hm, not sure why InnerDetector/InDetExample/InDetRecExample and Projects/WorkDir are also affected, was only mentioning TRTMonitoringRun3...

CI Result FAILURE (hash aef3d64b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27375]

Hi @nbelyaev,

I have added a couple of comments. Can you please take a look?

Cheers, Volker (L1)

added review-user-action-required label and removed review-pending-level-1 label

Hi @vaustrup , Thanks a lot for these comments! However, I wasn't planning to merge anything into InnerDetector/InDetExample/InDetRecExample and Projects/WorkDir. Is there any straightforward way to remove those one from the MR? Or I should close this one and recreate MR with TRTMonitoringRun3 only?

added 1 commit

• 23280500 - Changes of InDetExample and Projects/WorkDir are reverted

Compare with previous version

WARNING: big files (>100K) are found in the changeset

104K in file InnerDetector/InDetMonitoring/TRTMonitoringRun3/src/TRTMonitoringRun3RAW_Alg.cxx

This merge request affects 1 package:

• InnerDetector/InDetMonitoring/TRTMonitoringRun3

This merge request affects 9 files:

• InnerDetector/InDetMonitoring/TRTMonitoringRun3/TRTMonitoringRun3/TRTMonitoringRun3ESD_Alg.h
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/TRTMonitoringRun3/TRTMonitoringRun3RAW_Alg.h
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/python/TRTMonitoringRun3Config.py
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/python/TRTMonitoringRun3ESD_Alg.py
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/python/TRTMonitoringRun3RAW_Alg.py
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/python/TrackSummaryToolWorkaround.py
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/share/TRTMonitoringRun3RAW_Alg_jobOptions.py
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/src/TRTMonitoringRun3ESD_Alg.cxx
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/src/TRTMonitoringRun3RAW_Alg.cxx

Adding @cgrefe ,@calfayan ,@sroe ,@goetz as watchers

added review-pending-level-1 label and removed review-user-action-required label

Dear @vaustrup and @akraszna ,

Many thanks for your useful comments! I have reverted the changes to InDetExample and Projects/WorkDir. Considering the comments related to the TRTMonitoringRun3, I'll implement the fix asap.

CI Result SUCCESS (hash 23280500)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27541]

added 1 commit

• 510f750b - Identations fixed

Compare with previous version

WARNING: big files (>100K) are found in the changeset

104K in file InnerDetector/InDetMonitoring/TRTMonitoringRun3/src/TRTMonitoringRun3RAW_Alg.cxx

This merge request affects 1 package:

• InnerDetector/InDetMonitoring/TRTMonitoringRun3

This merge request affects 9 files:

• InnerDetector/InDetMonitoring/TRTMonitoringRun3/TRTMonitoringRun3/TRTMonitoringRun3ESD_Alg.h
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/TRTMonitoringRun3/TRTMonitoringRun3RAW_Alg.h
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/python/TRTMonitoringRun3Config.py
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/python/TRTMonitoringRun3ESD_Alg.py
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/python/TRTMonitoringRun3RAW_Alg.py
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/python/TrackSummaryToolWorkaround.py
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/share/TRTMonitoringRun3RAW_Alg_jobOptions.py
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/src/TRTMonitoringRun3ESD_Alg.cxx
• InnerDetector/InDetMonitoring/TRTMonitoringRun3/src/TRTMonitoringRun3RAW_Alg.cxx

Adding @cgrefe ,@calfayan ,@sroe ,@goetz as watchers

resolved all threads

CI Result SUCCESS (hash 510f750b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27579]

• Previous L1 review
• All tests passing
• Experts have seen the change

Approving (L1)

added review-approved label and removed review-pending-level-1 label

mentioned in commit 8d8700c7

merged

added sweep:ignore label