Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 164
    • Merge requests 164
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !40420

Merged
Created Feb 07, 2021 by Yuval Zach@yzach💬Contributor

Replace unsafe sprintf() in NSWL1Simulation::initialize()

  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

In NSWL1Simulation::initialize(), two calls are made to sprintf into a stack-allocated array. The format string is unbounded, meaning a name() longer than 36 characters (extremely unlikely) will result in a stack buffer overflow.

This replaces the sprintf and char arrays with C++ strings.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: hotfix/unsafe-sprintf