TCT q221: replacing MP test with serial

The TCT test q221_mp started to fail in the RDOtoRDOtrigger step since nightly from February 5, 2021 with the following error:

RuntimeError: RDOtoRDOTrigger requires AthenaMT, but serial Athena was used. Please use threads=1 or more

Based on ticket ATR-22498, the MP version cannot use MT enabled. This MR disables the MP version of this test and enables the serial version using MT.

Few other updates:

• added option --outputHISTFile=myHIST.root for the test q221_serial (it was accidentally removed in a previous MR)
• changed nprocs from 8 to 2 for the test q221_mp

Tagging @rmazini

This merge request affects 1 package:

• Tools/Tier0ChainTests

This merge request affects 2 files:

• Tools/Tier0ChainTests/test/test_q221_mp.sh
• Tools/Tier0ChainTests/test/test_q221_serial.sh

added Tools master review-pending-level-1 labels

CI Result FAILURE (hash 39f75cf2)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27777]

Please check for the failed tests and update the references if necessary.

added review-user-action-required label and removed review-pending-level-1 label

Jenkins please retry a build

added review-pending-level-1 label and removed review-user-action-required label

This merge request affects 1 package:

• Tools/Tier0ChainTests

This merge request affects 2 files:

• Tools/Tier0ChainTests/test/test_q221_mp.sh
• Tools/Tier0ChainTests/test/test_q221_serial.sh

added urgent label

CI Result SUCCESS (hash 39f75cf2)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27854]

added review-approved label and removed review-pending-level-1 label

I can push this MR through, no problems, but the only thing this fix does is to replace --nprocs=8 with --nprocs=2, which is just to change the number of AthenaMP workers, and not to diasable the MP version of this test and enables the serial version using MT, as stated in the description of this MR.

The line # art-include: master/Athena

ensures that it runs within the TCT nightly tests. For the test q221_mp, this line is removed, so the jobs will be not submitted for this test. For the other test (q221_serial), this line is added.

It is true that --nprocs=8 is replaced with --nprocs=2. I mention it in the description (but it is irrelevant).

Thanks for the explanation. Still I find this rather confusing: "enables serial version using MT". By serial we usually mean Athena with neither nprocs nor threads command-line switch. Even for --threads=1 we normally say "MT with one thread" and not "serial"

This is a good point! We will think about updating the naming convention. And thank you for the merge!

changed the description

resolved all threads

merged

mentioned in commit f91ababd

added sweep:ignore label