Skip to content
Snippets Groups Projects

New ITK seed maker

Merged Thomas Strebler requested to merge tstreble/athena:SeedMaker_ITKNew into 21.9

This MR introduces a new implementation of the ITK seed maker, based on the ATLxk implementation from master but keeping the ITk specificities.

https://gitlab.cern.ch/atlas/athena/-/blob/master/InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/SiSpacePointsSeedMaker_ATLxk.cxx

One of the main motivations is to investigate the impact of the seed confirmation on the fast tracking LRT, which is not available in the existing implementation.

All of the existing functionalities of the existing ITK seed maker are supposed to be reproduced with this implementation, which may be considered as some candidate for the future migration to master, when the expected performance are confirmed.

FYI @ncalace @nstyles @goblirsc @mdanning

Edited by Thomas Strebler

Merge request reports

Pipeline #2345500 passed

Pipeline passed for 9363ed22 on tstreble:SeedMaker_ITKNew

Approval is optional

Merged by Tadej NovakTadej Novak 4 years ago (Feb 25, 2021 2:20pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Thomas Strebler
  • Thomas Strebler
  • Thomas Strebler
  • added 1 commit

    Compare with previous version

  • Thomas Strebler
  • Thomas Strebler added 3 commits

    added 3 commits

    • 365d803c - Added ITKNew in SiSpacePointsSeedTool
    • 0a6e5979 - Fixed crash when running ITKNew SeedMaker
    • ce37adf2 - Fixes to ITKNew seed maker

    Compare with previous version

  • added 1 commit

    • 5ef40cc5 - Fixed typo for bottom links in PPP seeds

    Compare with previous version

  • added 1 commit

    • da60c152 - Fixed seed lists and iterator to usee ITK version

    Compare with previous version

  • Noemi Calace
  • Thomas Strebler added 43 commits

    added 43 commits

    Compare with previous version

  • Thomas Strebler resolved all threads

    resolved all threads

  • Thomas Strebler marked this merge request as ready

    marked this merge request as ready

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 120K in file InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/SiSpacePointsSeedMaker_ITKNew.cxx

  • This merge request affects 1 package:

    • InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk

    This merge request affects 7 files:

    • InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/SiSpacePointsSeedTool_xk/SiSpacePointForSeedITK.h
    • InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/SiSpacePointsSeedTool_xk/SiSpacePointsSeedMakerEventData.h
    • InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/SiSpacePointsSeedTool_xk/SiSpacePointsSeedMaker_ITK.h
    • InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/SiSpacePointsSeedTool_xk/SiSpacePointsSeedMaker_ITKNew.h
    • InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/SiSpacePointsSeedMaker_ITK.cxx
    • InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/SiSpacePointsSeedMaker_ITKNew.cxx
    • InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk/src/components/SiSpacePointsSeedTool_xk_entries.cxx

    Adding @goetz ,@amorley ,@gavrilen ,@sroe ,@jsandesa as watchers

  • :white_check_mark: CI Result SUCCESS (hash 164f9261)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :warning:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 104
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28872]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading