Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 144
    • Merge requests 144
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !40845

Move to using the TrigInDetConfig.ConfigSettings

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mark Sutton requested to merge sutt/athena:broken into master Feb 19, 2021
  • Overview 5
  • Commits 4
  • Pipelines 2
  • Changes 15

Added additional variables and implemented the fetching of the configuration from the Config Settings for the InDetTrigConfig code and the FTF Configuration.

Parameters can be set in pre-includes etc using eg

   from InDetTrigConfig.ConfgSettings import getInDetTrigConfig ; getInDetTrigConfig("Muon")._etaHalfWidth = 0.1

Also, for these changes we rename many of the variables, such that they more properly correspond to the variables that they are supposed to set to make it clearer what is being set and where.

In addition the unpleasant remapping of the slice names has now been removed - now you request a slice and the remapping in done at the level of the code to determine which config object is required, and then instead of using some ad hoc "remapped_type", we can simply request the actual slice name from the config object.

Also, some double underscores in the algorithm names have been reduced to a single underscore

Edited Feb 19, 2021 by Mark Sutton
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: broken