Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 175
    • Merge requests 175
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !40853

Merged
Created Feb 19, 2021 by Tomas Dado@tdadoDeveloper

Radiation damage code changes

  • Overview 3
  • Commits 2
  • Pipelines 1
  • Changes 2

This MR consists of 2 commits:

  • First commit skips a loop iteration if the original energy deposit from Geant4 is in an invalid Si cell - this changes the output - see below for plots. However, this should be considered more of a bug fix
  • Second commit brings speed improvements:
    • Removing one superfluous if condition in the 3D sensor (it is already satisfied in that part of the code)
    • Replaces a code where something like (1 - 2*bool) is used which was marked as being slow by VTune. This is beyond my c++/compiler optimisation knowledge why this is so slow, but it seems to be slow and it is fixed now.
    • The last change moves a calcualtion of one expensive part outside of the ncharge loop

The changes in the second commit bring no additional changes wrt the first commit.

cc @tadej @bnachman

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: RadiationDmgSpeedUp