Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 143
    • Merge requests 143
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !40878

Run3 L1 Calo simulation code clean up

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jon Burr requested to merge jburr/athena:L1CaloMigration into 21.3 Feb 19, 2021
  • Overview 66
  • Commits 63
  • Pipelines 4
  • Changes 78

This is the first step in the clean up of the Run 3 L1 calo floating point simulation code clean up, preparing for migration to release 22.

Main points:

  • Creation of a new package TrigT1CaloFexPerf. In r22, TrigT1CaloFexSim should be used for the bitwise simulation
  • Code cleaned up and migrated into this package as they are understood. So far the processing of J and G towers is migrated and all MET algorithms. These give equal results to their equivalents in the older package. The eFEX algorithms were also migrated by @stelzer
  • This involved creating a new xAOD class: xAOD::GBlock and its associated container classes. These may want the attention of @akraszna

Tagging @bcarlson as well.

Apologies for the very large number of changes in this MR. This migration involves rewriting some very complex code so it was necessary to have a lot of this infrastructure in place to test that the clean up was successful before a MR could be created. ATR-22750

Memory leak removed and cleaned up SCEmulation algorithm added.

Edited Feb 26, 2021 by Jon Burr
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: L1CaloMigration