Skip to content
Snippets Groups Projects

jFEXSmallRJet EDM for L1Calo Bitwise Offline Simulation

Closed jFEXSmallRJet EDM for L1Calo Bitwise Offline Simulation
vasothil/athena:jFEX_EDM into master
Closed Varsiha Sothilingam requested to merge vasothil/athena:jFEX_EDM into master

Completed Small R Jet EDM for jFEX. Also implemented in main algorithm. MR also contains some minor changes and tidying up in algorithm files.

@jkempste

Edited by Varsiha Sothilingam

Merge request reports

Pipeline #2386940 passed

Stage: external

    Pipeline passed for 5d657032 on vasothil:jFEX_EDM

    Approval is optional

    Closed by Varsiha SothilingamVarsiha Sothilingam 3 years ago (Mar 29, 2021 9:46am UTC)

    Merge details

    • The changes were not merged into master.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Varsiha Sothilingam marked this merge request as draft

    marked this merge request as draft

  • Varsiha Sothilingam added 1 commit

    added 1 commit

    • cf28d94b - fixed bug in EDM, added saturation flags in EDM + algo

    Compare with previous version

  • Varsiha Sothilingam added 1 commit

    added 1 commit

    Compare with previous version

  • Varsiha Sothilingam added 1 commit

    added 1 commit

    Compare with previous version

  • Varsiha Sothilingam marked this merge request as ready

    marked this merge request as ready

  • Varsiha Sothilingam resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Event/xAOD/xAODTrigger
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
    • Trigger/TrigT1/L1CaloFEXToolInterfaces

    Affected files list will not be printed in this case

    Adding @tamartin ,@akraszna ,@kwhalen ,@afaulkne as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Alison Elliot
    Alison Elliot @afaulkne ·

    Hi Varsiha, I've reviewed your merge request, and I have no comments. It looks great - thanks!

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash e3af7231)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :warning: :warning:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :warning: AnalysisBase: number of compilation errors 0, warnings 1
    :warning: AthAnalysis: number of compilation errors 0, warnings 1
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28988]

  • Mike Hance added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Varsiha Sothilingam added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Event/xAOD/xAODTrigger
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
    • Trigger/TrigT1/L1CaloFEXToolInterfaces

    Affected files list will not be printed in this case

    Adding @tamartin ,@akraszna ,@kwhalen ,@afaulkne as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 231d2e8f)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29019]

  • Volker Andreas Austrup resolved all threads

    resolved all threads

  • V
    Volker Andreas Austrup @vaustrup ·
    Developer

    Hi @vasothil,

    just a small comment about lines that could be removed. Please take a look.

    Thanks, Volker (L1)

  • Volker Andreas Austrup added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Varsiha Sothilingam added 1 commit

    added 1 commit

    • 1c480cb4 - extra debug statements removed from jFEXSmallRJetAlgo

    Compare with previous version

  • Varsiha Sothilingam resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Event/xAOD/xAODTrigger
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
    • Trigger/TrigT1/L1CaloFEXToolInterfaces

    Affected files list will not be printed in this case

    Adding @tamartin ,@akraszna ,@kwhalen ,@afaulkne as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 1c480cb4)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29164]

  • Louis-Guillaume Gagnon
    Louis-Guillaume Gagnon @lgagnon ·
    Developer

    CI passes, reviewed already by multiple persons, approved -- L1

  • Louis-Guillaume Gagnon added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Adam Edward Barton removed review-approved label

    removed review-approved label

  • Adam Edward Barton added review-user-action-required label

    added review-user-action-required label

  • Adam Edward Barton
    Adam Edward Barton @abarton ·
    Developer

    Delaying for Atilla's issue.

  • Attila Krasznahorkay
  • Varsiha Sothilingam added 1 commit

    added 1 commit

    Compare with previous version

  • V
    Varsiha Sothilingam @vasothil ·
    Author Developer

    Hi, Thank you for all the comments. I have made the appropriate changes to the EDM.

    Varsiha

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Event/xAOD/xAODTrigger
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
    • Trigger/TrigT1/L1CaloFEXToolInterfaces

    Affected files list will not be printed in this case

    Adding @tamartin ,@akraszna ,@kwhalen ,@afaulkne as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash ec8363cd)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :o: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :o: AthGeneration: number of compilation errors 1, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29451]

  • V
    Varsiha Sothilingam @vasothil ·
    Author Developer

    Hi, just looking at the other MR and it looks like I also need to edit Event/xAOD/xAODTriggerAthenaPool/CMakeLists.txt which I will do now. Is there anything else I have missed?

  • Abhishek Nag added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Varsiha Sothilingam added 1 commit

    added 1 commit

    • 008d7c6c - added changes to xAODTriggerAthenaPool CMakeLists

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Event/xAOD/xAODTrigger
    • Event/xAOD/xAODTriggerAthenaPool
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
    • Trigger/TrigT1/L1CaloFEXToolInterfaces

    Affected files list will not be printed in this case

    Adding @tamartin ,@akraszna ,@kwhalen ,@afaulkne as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply