script for testing AFP COOL DB with alignment constants

Update/Add a script that will create a COOL DB with alignment constants for AFP. Also added some classes to be used later.

(Trigger/TriggerCommon/TrigEDMConfig/python/TriggerEDMRun3.py shall not be changed! It's unclear why it has any changes... This should be OK now)

added 1 commit

• 5d433253 - trying to fix TriggerEDMRun3.py

Compare with previous version

added 1 commit

• 81336b2a - fixing TriggerEDMRun3.py

Compare with previous version

added ForwardDetectors master labels

changed the description

unassigned @pbalek

marked this merge request as ready

This merge request affects 1 package:

• ForwardDetectors/AFP/AFP_DBTools

This merge request affects 9 files:

• ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/ISiGlobAlignDBTool.h
• ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/SiGlobAlignDBTool.h
• ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/SiGlobAlignData.h
• ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/SiGlobAlignDataBuilder.h
• ForwardDetectors/AFP/AFP_DBTools/python/AFPDBBase.py
• ForwardDetectors/AFP/AFP_DBTools/scripts/AFPLocalAlignDBCreate.py
• ForwardDetectors/AFP/AFP_DBTools/src/SiGlobAlignDBTool.cxx
• ForwardDetectors/AFP/AFP_DBTools/src/SiGlobAlignDataBuilder.cxx
• ForwardDetectors/AFP/AFP_DBTools/src/components/AFP_DBTools_entries.cxx

Adding @ggach as watcher

added review-pending-level-1 label

CI Result FAILURE (hash 81336b2a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29157]

The flake8 unit test is now failing:

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/ForwardDetectors/AFP/AFP_DBTools/scripts/AFPLocalAlignDBCreate.py:13:1: warning: F401 'os' imported but unused
import os,sys
^
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/ForwardDetectors/AFP/AFP_DBTools/scripts/AFPLocalAlignDBCreate.py:92:23: warning: E703 statement ends with a semicolon
            channel+=0;
                      ^
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/ForwardDetectors/AFP/AFP_DBTools/scripts/AFPLocalAlignDBCreate.py:94:23: warning: E703 statement ends with a semicolon
            channel+=1;
                      ^
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/ForwardDetectors/AFP/AFP_DBTools/scripts/AFPLocalAlignDBCreate.py:96:23: warning: E703 statement ends with a semicolon
            channel+=2;
                      ^
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/ForwardDetectors/AFP/AFP_DBTools/scripts/AFPLocalAlignDBCreate.py:98:23: warning: E703 statement ends with a semicolon
            channel+=3;
                      ^
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/ForwardDetectors/AFP/AFP_DBTools/scripts/AFPLocalAlignDBCreate.py:134:9: warning: F811 redefinition of unused 'os' from line 13
        import os
        ^
warning: Python code violations found. See <https://gitlab.cern.ch/atlas/atlasexternals/tree/master/External/flake8_atlas>.

-- L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 1cb54ecd - fix flake8

Compare with previous version

This merge request affects 1 package:

• ForwardDetectors/AFP/AFP_DBTools

This merge request affects 9 files:

• ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/ISiGlobAlignDBTool.h
• ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/SiGlobAlignDBTool.h
• ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/SiGlobAlignData.h
• ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/SiGlobAlignDataBuilder.h
• ForwardDetectors/AFP/AFP_DBTools/python/AFPDBBase.py
• ForwardDetectors/AFP/AFP_DBTools/scripts/AFPLocalAlignDBCreate.py
• ForwardDetectors/AFP/AFP_DBTools/src/SiGlobAlignDBTool.cxx
• ForwardDetectors/AFP/AFP_DBTools/src/SiGlobAlignDataBuilder.cxx
• ForwardDetectors/AFP/AFP_DBTools/src/components/AFP_DBTools_entries.cxx

Adding @ggach as watcher

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 1cb54ecd)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29199]

Hi,

changes look fine from L1 side, but it would be good if L2 could have a look at the new classes this adds as well.

Cheers, Volker (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

MR looks good apart from a minor comment: the start year of the CERN copyright is missing in the new files added.

Cheers Abhishek [L2]

Hello @abnag, these are new files created in 2021. Should I put there Copyright (C) 2021-2021 CERN ?

Thank you Petr

Hi @pbalek, the files may be new but the CERN Copyright started in 2002.

Abhishek

added 1 commit

• 7f8ab3c8 - fix of the copyright

Compare with previous version

This merge request affects 1 package:

• ForwardDetectors/AFP/AFP_DBTools

This merge request affects 9 files:

• ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/ISiGlobAlignDBTool.h
• ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/SiGlobAlignDBTool.h
• ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/SiGlobAlignData.h
• ForwardDetectors/AFP/AFP_DBTools/AFP_DBTools/SiGlobAlignDataBuilder.h
• ForwardDetectors/AFP/AFP_DBTools/python/AFPDBBase.py
• ForwardDetectors/AFP/AFP_DBTools/scripts/AFPLocalAlignDBCreate.py
• ForwardDetectors/AFP/AFP_DBTools/src/SiGlobAlignDBTool.cxx
• ForwardDetectors/AFP/AFP_DBTools/src/SiGlobAlignDataBuilder.cxx
• ForwardDetectors/AFP/AFP_DBTools/src/components/AFP_DBTools_entries.cxx

Adding @ggach as watcher

added review-pending-level-1 label and removed review-pending-level-2 label

Hi @abnag, I see, thank you! I've fixed it.

Cheers, Petr

resolved all threads

CI Result SUCCESS (hash 7f8ab3c8)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29248]

Comments from L2 have been addressed. Approving.

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit d0dd1ae0

added sweep:ignore label