Implementation of TrigEFTauDiKaonHypoTool for Run-3 meson+gamma triggers

Implements the purely tau meson-mass hypothesis tool, TrigEFTauDiKaonHypoTool, for the following trigger chains used in exclusive meson+photon Higgs/Z/W boson decay searches:

• HLT_g25_medium_tau25_dikaonmass_tracktwoMVA_50mVis10000
• HLT_g25_medium_tau25_kaonpi1_tracktwoMVA_50mVis10000
• HLT_g25_medium_tau25_kaonpi2_tracktwoMVA_50mVis10000
• HLT_g25_medium_tau25_singlepion_tracktwoMVA_50mVis10000
• HLT_g35_medium_tau25_dipion3_tracktwoMVA_60mVis10000

Related JIRA ticket: https://its.cern.ch/jira/browse/ATR-22644

The chain segments dikaonmass, kaonpi1/2, singlepion and dipion3 are purely tau hypotheses that use the TrigEFTauDiKaonHypoTool class, which has been ported from its Run-2 equivalent. The chain segments are entered in the tau selection chain-part in the signature dictionary. This hypothesis is based on TrigEFTauMVHypoTool, and is implemented on the menu side as an alternative option in within TrigEFTauMVHypoToolFromDict.

The chain segment 50mVis10000 is a tau+photon combo invariant mass hypothesis. This will be implemented in a later merge request.

This implementation does not affect chains that use the standard TrigEFTauMVHypoTool tool.

added 2 commits

• 2dd1ab55 - Deletes commented code
• 5f1b17aa - Revert dipion3 chain back to g35 and 60mVis10000

Compare with previous version

added 316 commits

• 5f1b17aa...5d84d013 - 312 commits from branch atlas:master
• 1fd6ec37 - Remove mVis combo hypo tool in menus
• a6cba031 - Merge branch 'master' into run3-mesonGammaTrig
• edb18e02 - Revert "Merge branch 'feature-mesonGammaTrigImplimentation' into 'run3-mesonGammaTrig'"
• 07927673 - Reference file patches for new triggers

Compare with previous version

changed title from WIP: Implementation of meson+gamma triggers for Run-3 to WIP: Implementation of TrigEFTauDikaonHypoTool for Run-3 meson+gamma triggers

changed title from WIP: Implementation of TrigEFTauDikaonHypoTool for Run-3 meson+gamma triggers to WIP: Implementation of TrigEFTauDiKaonHypoTool for Run-3 meson+gamma triggers

changed the description

marked this merge request as ready

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigTauHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@martindl ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

added Tau Trigger TriggerMenu changes-trigger-counts master review-pending-level-1 labels

changed the description

CI Result SUCCESS (hash 07927673)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30063]

Sorry, just a few more minor comments above, only on copyright statements. Once these are in, please resolve all threads and we can approve. -Mike (L1)

added review-user-action-required label and removed review-pending-level-1 label

related to ATR-22644

added 362 commits

• 07927673...c3849bf8 - 360 commits from branch atlas:master
• 1f93a8b3 - Merge branch 'master' into run3-mesonGammaTrig
• 9b3d0328 - Update copyright statements

Compare with previous version

changed the description

resolved all threads

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigTauHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@martindl ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 9b3d0328)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30380]

@roward I added a minor comment to be resolved, otherwise this looks quite good.

There are a few test failures which I don't think are related (seeing some of them in other MR's as well) but this should be double-checked. Otherwise let's see if they stick around when CI re-runs.

Cheers, -- L1

added review-user-action-required label and removed review-pending-level-1 label

added 194 commits

• 9b3d0328...3ed7b411 - 191 commits from branch atlas:master
• a0cdc4d1 - Merge branch 'master' into run3-mesonGammaTrig
• 3d704659 - Change to std::abs from fabs
• b4eb5bae - Merge branch 'master' into run3-mesonGammaTrig

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigTauHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@martindl ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash b4eb5bae)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30613]

resolved all threads

Jenkins please retry a build

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigTauHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@martindl ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

CI Result FAILURE (hash b4eb5bae)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30711]

added 188 commits

• b4eb5bae...8b754da3 - 184 commits from branch atlas:master
• 4a953162 - Merge branch 'master' into run3-mesonGammaTrig
• ad0ec260 - Changes L1 item from L1TAU12 to L1EM22VHI
• 54cd93de - Revert "Reference file patches for new triggers"
• 14ff9101 - Reference file patches for meson+gamma triggers using L1EM22VHI

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigTauHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@martindl ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

resolved all threads

resolved all threads

CI Result SUCCESS (hash 14ff9101)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30816]

Hi,

the CI passes now, but unfortunately this MR caught merge conflicts. Can you please resolve them?

Thanks, Volker (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 70 commits

• 14ff9101...90611e41 - 69 commits from branch atlas:master
• fa70154e - Merge branch 'master' into run3-mesonGammaTrig

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigTauHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@martindl ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

added review-pending-level-1 label and removed review-user-action-required label

added 1 commit

• c908bebc - Fix spacing in LS2 menu

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigTauHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@martindl ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

CI Result FAILURE (hash c908bebc)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30883]

CI Result FAILURE (hash fa70154e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30881]