Skip to content

ExpressionEvaluation fix clang warning

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:ExpressionEvaluation_fix_clang10_warnings into master

Should fix

n file included from /build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/SGxAODProxyLoader.cxx:22:
/build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/BaseAccessor.h:43:19: warning: 'loadInt' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
      virtual int loadInt(const EventContext& ctx) const { (void) ctx; throwEmptyVector(); return 0; }
                  ^
/build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/IAccessor.h:17:19: note: overridden virtual function is here
      virtual int loadInt(const EventContext& ctx) const = 0;
                  ^
In file included from /build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/SGxAODProxyLoader.cxx:22:
/build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/BaseAccessor.h:44:22: warning: 'loadDouble' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
      virtual double loadDouble(const EventContext& ctx) const { (void) ctx; throwEmptyVector(); return 0.;}
                     ^
/build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/IAccessor.h:18:22: note: overridden virtual function is here
      virtual double loadDouble(const EventContext& ctx) const = 0;
                     ^
In file included from /build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/SGxAODProxyLoader.cxx:22:
/build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/BaseAccessor.h:45:32: warning: 'loadVecInt' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
      virtual std::vector<int> loadVecInt(const EventContext& ctx) const { (void) ctx; return std::vector<int>(); }
                               ^
/build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/IAccessor.h:19:32: note: overridden virtual function is here
      virtual std::vector<int> loadVecInt(const EventContext& ctx) const = 0;
                               ^
In file included from /build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/SGxAODProxyLoader.cxx:22:
/build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/BaseAccessor.h:46:35: warning: 'loadVec' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
      virtual std::vector<double> loadVec(const EventContext& ctx) const { (void) ctx; return std::vector<double>(); }
                                  ^
/build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/IAccessor.h:20:35: note: overridden virtual function is here
      virtual std::vector<double> loadVec(const EventContext& ctx) const = 0;
                                  ^
In file included from /build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/SGxAODProxyLoader.cxx:25:
/build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/PlainAccessor.h:60:37: warning: unused parameter 'cont' [-Wunused-parameter]
      std::size_t size(const T_src &cont) const {
                                    ^
/build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/SGxAODProxyLoader.cxx:169:85: warning: expression with side effects will be evaluated despite being used as an operand to 'typeid' [-Wpotentially-evaluated-expression]
    if (m_verbose) { std::cout << "DEBUG SGxAODProxyLoader use accessor " << typeid(*accessor).name() << " for " <<varname << std::endl; }
                                                                                    ^
/build/atnight/localbuilds/nightlies/Athena/master/athena/PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/SGxAODProxyLoader.cxx:252:48: warning: unused variable 'handle_full_key' [-Wunused-variable]
                              std::string_view handle_full_key(handle_key);

Mentioning @ssnyder and @goetz

Merge request reports