Skip to content

TrigConfiguration: thread-checker fixes

Frank Winklmeier requested to merge fwinkl/athena:thrchk_trigconf into master

Several fixes to trigger configuration packages to enable the static thread-checker:

  • TrigConfData:
    • Remove custom checker macros. Since we are building CxxUtils in DetCommon we may as well rely on the official thread checker macros from CxxUtils.
  • TrigConfxAOD:
    • Enable thread checker by marking mutables as thread-safe (they are locked). Also cleanup link dependencies and move the private KeyWriterTool.h to the src/ directory.
  • TrigConfIO:
    • Remove usage of strtok (the code was dead anyway) and update documentation.
    • Do not cache schema version and leave this up to the caller. In all current cases, the DB loader is instantiated every time a DB access occurs so this caching did not really bring any improvement.
  • TrigConfJobOptData+TrigConfJobOptData:
    • enable thread-checker (no fixes needed)

cc @stelzer

Edited by Frank Winklmeier

Merge request reports