Adjustment bins and ranges in the Online Monitoring for reconstruction algorihtms

This MR is for updating the bins and ranges of the histograms in Online Monitoring for reconstruction algorithms. Some typos were also corrected. This has been discussed in ATR-22547.

ping @fernando , @cjmeyer , @jodafons and @safarzad .

added DQ Egamma Trigger master labels

changed the description

This merge request affects 1 package:

• Trigger/TrigMonitoring/TrigEgammaMonitoring

This merge request affects 5 files:

• Trigger/TrigMonitoring/TrigEgammaMonitoring/python/egammaMonitorPrecisionConfig.py
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorElectronAlgorithm.cxx
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorElectronAlgorithm.h
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorPhotonAlgorithm.cxx
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorPhotonAlgorithm.h

Adding @dbakshig ,@cjmeyer ,@fernando as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 052444e1)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30007]

The histogram changes look fine, but I'm not sure about the macros you've introduced. I think these are discouraged in ATLAS and in this case I'm not sure there is a huge benefit. Sending to L2 to review. Tom - L1 shifter

added review-pending-level-2 label and removed review-pending-level-1 label

I am also not aware of the GETTER() used as a macro for plotting. @eegidiop can you throw some light on it? Cheers, Abhishek [L2]

added review-user-action-required label

added 1 commit

• 25cf0b32 - Fix macros

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigMonitoring/TrigEgammaMonitoring

This merge request affects 6 files:

• Trigger/TrigMonitoring/TrigEgammaMonitoring/python/TrigEgammaMonitoringMTConfig.py
• Trigger/TrigMonitoring/TrigEgammaMonitoring/python/egammaMonitorPrecisionConfig.py
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorElectronAlgorithm.cxx
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorElectronAlgorithm.h
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorPhotonAlgorithm.cxx
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorPhotonAlgorithm.h

Adding @dbakshig ,@cjmeyer ,@fernando as watchers

added review-pending-level-1 label and removed review-pending-level-2 review-user-action-required labels

marked this merge request as draft

CI Result FAILURE (hash 25cf0b32)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30345]

Marked as draft, so removing the review label for now. @eegidiop just add it back if you want a review now anyways, otherwise the ATLAS robot will take care of it once you mark this as ready. -- L1

removed review-pending-level-1 label

added 364 commits

• 25cf0b32...38409b66 - 356 commits from branch atlas:master
• df7b3e41 - Update bins and ranges in the Online Mon Reco Algos
• db0d0fd2 - Adjustment bins and ranges in the online monitoring for reconstruction algos
• 64afd752 - Include cern copyright in some algorithms
• 17e51ad7 - Adjustment bins and ranges in the OnlineMon for Reco Algos
• 75c38bec - Adjustment bins and ranges in the online monitoring for reconstruction algos
• 5fb33f03 - Fix macros
• d2976be6 - Include base class to unify the filling of monitoring variables
• cd2d7e74 - Include base class to unify the filling of monitoring variables

Compare with previous version

added 385 commits

• cd2d7e74...4bfb7f00 - 377 commits from branch atlas:master
• e227d30a - Update bins and ranges in the Online Mon Reco Algos
• e23f7644 - Adjustment bins and ranges in the online monitoring for reconstruction algos
• 38b17055 - Include cern copyright in some algorithms
• 981c86d3 - Adjustment bins and ranges in the OnlineMon for Reco Algos
• 148675d2 - Adjustment bins and ranges in the online monitoring for reconstruction algos
• ffa83915 - Fix macros
• 7741a9c4 - Include base class to unify the filling of monitoring variables
• 10f39da5 - Fix conflicts

Compare with previous version

marked this merge request as ready

This merge request affects 1 package:

• Trigger/TrigMonitoring/TrigEgammaMonitoring

This merge request affects 11 files:

• Trigger/TrigMonitoring/TrigEgammaMonitoring/python/TrigEgammaMonitoringMTConfig.py
• Trigger/TrigMonitoring/TrigEgammaMonitoring/python/egammaMonitorPrecisionConfig.py
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/components/TrigEgammaMonitoring_entries.cxx
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorBaseAlgorithm.cxx
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorBaseAlgorithm.h
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorElectronAlgorithm.cxx
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorElectronAlgorithm.h
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorPhotonAlgorithm.cxx
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorPhotonAlgorithm.h
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorSuperClusterAlgorithm.cxx
• Trigger/TrigMonitoring/TrigEgammaMonitoring/src/egammaMonitorSuperClusterAlgorithm.h

Adding @dbakshig ,@cjmeyer ,@fernando as watchers