Skip to content

CaloNoise CDO: Explicitly delete accessor by HWIdentifier

Walter Lampl requested to merge wlampl/athena:CaloNoiseSafetyNet into master

While working on !41601 (merged) I discovered a case where the CaloNoise conditions data object was accessed with a HWIdentifier (aka online identifier) but it expects an Identifier (aka offline identifier). This compiles and runs but returns garbage. To make it worse, it's hard-to-detect garbage, in many cases the noise of a different cell. To execute as fast as possible, neither the CaloNoise CDO nor the CaloCell_ID identifier helper do any checks on their inputs.

With this MR, the accessor by HWIdentifier is explicitly deleted, so the above-mentioned mistake will not compile any longer. The CI will show if there are more cases like the one I discovered in LArShapeDumper.cxx

cc @pavol for info ...

Merge request reports

Loading