Skip to content
Snippets Groups Projects

L1Topo kinematics phase1 upgrade-I

Merged L1Topo kinematics phase1 upgrade-I
asonay/athena:L1Topo-phase1-kinematics into master
All threads resolved!
Merged Anil Sonay requested to merge asonay/athena:L1Topo-phase1-kinematics into master
All threads resolved!

This MR is aiming to make able the L1Topo algorithms switch between phase1/legacy.

cc, @orlando , @cmorenom , @paulama , @iriu

Edited by Anil Sonay

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • M
    Mike Hance @mhance ·
    Developer

    Changes look OK, I only have one question above that it might be nice to have the L2 reviewer weigh in on. -Mike (L1)

  • Mike Hance added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • Anil Sonay added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Trigger/TrigT1/L1Topo/L1TopoAlgorithms
    • Trigger/TrigT1/L1Topo/L1TopoInterfaces
    • Trigger/TrigT1/L1Topo/L1TopoSimulation
    • Trigger/TrigT1/L1Topo/L1TopoSimulationUtils

    Affected files list will not be printed in this case

    Adding @jchapman ,@asonay ,@kwhalen ,@orlando ,@cmorenom ,@afaulkne as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-pending-level-2 label

    added review-pending-level-1 label and removed review-pending-level-2 label

  • Anil Sonay resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 7cd64743)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30224]

  • Thomas James Neep added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • Abhishek Nag
    Abhishek Nag @abnag ·

    Threads resolved. MR looks good. Approving.

    Cheers, Abhishek [L2]

  • Abhishek Nag added review-approved label and removed review-pending-level-2 label

    added review-approved label and removed review-pending-level-2 label

  • Adam Edward Barton merged

    merged

  • Adam Edward Barton mentioned in commit 0635e83a

    mentioned in commit 0635e83a

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply