Further updates of McEventCollection codes
In this MR, for HepMC3 branch:
- Modify functions so the particles are added to vertices before manipulations with their attributes. Used only in HepMC3 branch.
- Modify functions so the vertices are added to events before manipulations with their attributes. Used only in HepMC3 branch.
- Fix status() for vertices
- Some formating.
Tag @jchapman
Merge request reports
Activity
This merge request affects 1 package:
- Generators/GeneratorObjectsTPCnv
This merge request affects 8 files:
- Generators/GeneratorObjectsTPCnv/GeneratorObjectsTPCnv/McEventCollectionCnv_p2.h
- Generators/GeneratorObjectsTPCnv/GeneratorObjectsTPCnv/McEventCollectionCnv_p3.h
- Generators/GeneratorObjectsTPCnv/GeneratorObjectsTPCnv/McEventCollectionCnv_p4.h
- Generators/GeneratorObjectsTPCnv/GeneratorObjectsTPCnv/McEventCollectionCnv_p5.h
- Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p2.cxx
- Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p3.cxx
- Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p4.cxx
- Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p5.cxx
added Generators master review-pending-level-1 labels
CI Result FAILURE (hash b0926229)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 2
AthSimulation: number of compilation errors 1, warnings 0
AthGeneration: number of compilation errors 1, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30227]added review-user-action-required label and removed review-pending-level-1 label
added 12 commits
-
b0926229...f4935c90 - 10 commits from branch
atlas:master
- e19b3ce5 - Merge remote-tracking branch 'upstream/master' into hepmc3_nightly_fixes_18032021_part_3
- 48f78c53 - Fixes
-
b0926229...f4935c90 - 10 commits from branch
This merge request affects 1 package:
- Generators/GeneratorObjectsTPCnv
This merge request affects 8 files:
- Generators/GeneratorObjectsTPCnv/GeneratorObjectsTPCnv/McEventCollectionCnv_p2.h
- Generators/GeneratorObjectsTPCnv/GeneratorObjectsTPCnv/McEventCollectionCnv_p3.h
- Generators/GeneratorObjectsTPCnv/GeneratorObjectsTPCnv/McEventCollectionCnv_p4.h
- Generators/GeneratorObjectsTPCnv/GeneratorObjectsTPCnv/McEventCollectionCnv_p5.h
- Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p2.cxx
- Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p3.cxx
- Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p4.cxx
- Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p5.cxx
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash 48f78c53)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30278]added review-approved label and removed review-pending-level-1 label
mentioned in commit bc5dff38
added sweep:ignore label
mentioned in merge request !41862 (merged)
mentioned in merge request !41847 (closed)