Skip to content
Snippets Groups Projects

split enableL1Phase1 flag (ATR-23110)

Merged Daniele Zanzi requested to merge dzanzi/athena:ATR-phase1flag into master
All threads resolved!

This is to split the enableL1Phase1 flag into enableL1MuonPhase1 and enableL1CaloPhase1 to allow the phase1 development in parallel. Also related to ATR-19328, ATR-23071

@fwinkl @rbielski @wiedenma @smh @stelzer @masato @armbrust , can you please check these changes are OK?

Edited by Daniele Zanzi

Merge request reports

Pipeline #2453405 passed

Pipeline passed for f9464c9b on dzanzi:ATR-phase1flag

Merged by Johannes ElmsheuserJohannes Elmsheuser 3 years ago (Apr 5, 2021 5:54am UTC)

Merge details

  • Changes merged into master with 158f7b6d (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniele Zanzi added 1 commit

    added 1 commit

    • 7f435cc6 - trying to fix errors in L1TriggerResultMaker

    Compare with previous version

  • Daniele Zanzi changed the description

    changed the description

  • Daniele Zanzi added 1 commit

    added 1 commit

    Compare with previous version

  • Daniele Zanzi
  • Daniele Zanzi added 1 commit

    added 1 commit

    • 1cabf25f - fixing flag in L1TopoSimulationConfig

    Compare with previous version

  • Daniele Zanzi added 57 commits

    added 57 commits

    • 1cabf25f...b3a8609a - 56 commits from branch atlas:master
    • ca5a27cb - Merge remote-tracking branch 'upstream/master' into ATR-phase1flag

    Compare with previous version

  • Daniele Zanzi changed the description

    changed the description

  • Jenkins please retry a build

  • This merge request affects 14 packages:

    • HLT/Trigger/TrigControl/TrigExamples/TrigExPartialEB
    • MuonSpectrometer/MuonCnv/MuonCnvExample
    • MuonSpectrometer/MuonConfig
    • PhysicsAnalysis/AnalysisTrigger/AnalysisTriggerAlgs
    • Simulation/Digitization
    • Trigger/TrigAlgorithms/TrigL2MuonSA
    • Trigger/TrigSteer/L1Decoder
    • Trigger/TrigT1/L1Topo/L1TopoSimulation
    • Trigger/TrigT1/TrigT1CTMonitoring
    • Trigger/TrigT1/TrigT1CTP
    • Trigger/TrigT1/TrigT1ResultByteStream
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @jchapman ,@rosati ,@vmartin ,@okumura ,@fwinkl ,@wiedenma ,@cmorenom ,@bernius ,@asonay ,@jojungge ,@afaulkne ,@sutt ,@dzanzi ,@wleight ,@kwhalen ,@orlando ,@tamartin ,@hrussell ,@rbielski as watchers

  • Alison Elliot
  • :white_check_mark: CI Result SUCCESS (hash ca5a27cb)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30697]

  • Daniele Zanzi added 164 commits

    added 164 commits

    • ca5a27cb...90611e41 - 161 commits from branch atlas:master
    • f5053bf8 - Merge remote-tracking branch 'upstream/master' into ATR-phase1flag
    • 331fad4e - Merge remote-tracking branch 'upstream/master' into ATR-phase1flag
    • cfefe56c - adding L1Topo sim

    Compare with previous version

  • Daniele Zanzi added 52 commits

    added 52 commits

    • cfefe56c...63fa2bdd - 51 commits from branch atlas:master
    • 2ef1b491 - Merge remote-tracking branch 'upstream/master' into ATR-phase1flag

    Compare with previous version

  • Jenkins please retry a build

  • This merge request affects 14 packages:

    • HLT/Trigger/TrigControl/TrigExamples/TrigExPartialEB
    • MuonSpectrometer/MuonCnv/MuonCnvExample
    • MuonSpectrometer/MuonConfig
    • PhysicsAnalysis/AnalysisTrigger/AnalysisTriggerAlgs
    • Simulation/Digitization
    • Trigger/TrigAlgorithms/TrigL2MuonSA
    • Trigger/TrigSteer/L1Decoder
    • Trigger/TrigT1/L1Topo/L1TopoSimulation
    • Trigger/TrigT1/TrigT1CTMonitoring
    • Trigger/TrigT1/TrigT1CTP
    • Trigger/TrigT1/TrigT1ResultByteStream
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @jchapman ,@rosati ,@vmartin ,@okumura ,@fwinkl ,@wiedenma ,@cmorenom ,@bernius ,@asonay ,@jojungge ,@afaulkne ,@sutt ,@dzanzi ,@wleight ,@kwhalen ,@orlando ,@tamartin ,@hrussell ,@rbielski as watchers

  • Daniele Zanzi mentioned in merge request !41943 (closed)

    mentioned in merge request !41943 (closed)

  • Daniele Zanzi changed the description

    changed the description

  • :white_check_mark: CI Result SUCCESS (hash 2ef1b491)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30899]

  • Daniele Zanzi added 41 commits

    added 41 commits

    • 2ef1b491...9a8109fd - 40 commits from branch atlas:master
    • c08db675 - Merge remote-tracking branch 'upstream/master' into ATR-phase1flag

    Compare with previous version

  • Daniele Zanzi added 1 commit

    added 1 commit

    • 31d0efd7 - disable L1Topo Phase1 sim for now

    Compare with previous version

  • Daniele Zanzi marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 14 packages:

    • HLT/Trigger/TrigControl/TrigExamples/TrigExPartialEB
    • MuonSpectrometer/MuonCnv/MuonCnvExample
    • MuonSpectrometer/MuonConfig
    • PhysicsAnalysis/AnalysisTrigger/AnalysisTriggerAlgs
    • Simulation/Digitization
    • Trigger/TrigAlgorithms/TrigL2MuonSA
    • Trigger/TrigSteer/L1Decoder
    • Trigger/TrigT1/L1Topo/L1TopoSimulation
    • Trigger/TrigT1/TrigT1CTMonitoring
    • Trigger/TrigT1/TrigT1CTP
    • Trigger/TrigT1/TrigT1ResultByteStream
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @jchapman ,@rosati ,@vmartin ,@okumura ,@fwinkl ,@wiedenma ,@cmorenom ,@bernius ,@asonay ,@jojungge ,@afaulkne ,@sutt ,@dzanzi ,@wleight ,@kwhalen ,@orlando ,@tamartin ,@hrussell ,@rbielski as watchers

  • Daniele Zanzi resolved all threads

    resolved all threads

  • Daniele Zanzi added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 14 packages:

    • HLT/Trigger/TrigControl/TrigExamples/TrigExPartialEB
    • MuonSpectrometer/MuonCnv/MuonCnvExample
    • MuonSpectrometer/MuonConfig
    • PhysicsAnalysis/AnalysisTrigger/AnalysisTriggerAlgs
    • Simulation/Digitization
    • Trigger/TrigAlgorithms/TrigL2MuonSA
    • Trigger/TrigSteer/L1Decoder
    • Trigger/TrigT1/L1Topo/L1TopoSimulation
    • Trigger/TrigT1/TrigT1CTMonitoring
    • Trigger/TrigT1/TrigT1CTP
    • Trigger/TrigT1/TrigT1ResultByteStream
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @jchapman ,@rosati ,@vmartin ,@okumura ,@fwinkl ,@wiedenma ,@cmorenom ,@bernius ,@asonay ,@jojungge ,@afaulkne ,@sutt ,@dzanzi ,@wleight ,@kwhalen ,@orlando ,@tamartin ,@hrussell ,@rbielski as watchers

  • Daniele Zanzi marked this merge request as draft

    marked this merge request as draft

  • :white_check_mark: CI Result SUCCESS (hash 91c03286)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30978]

  • :white_check_mark: CI Result SUCCESS (hash 31d0efd7)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30977]

  • Daniele Zanzi added 49 commits

    added 49 commits

    Compare with previous version

  • Daniele Zanzi marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 14 packages:

    • HLT/Trigger/TrigControl/TrigExamples/TrigExPartialEB
    • MuonSpectrometer/MuonCnv/MuonCnvExample
    • MuonSpectrometer/MuonConfig
    • PhysicsAnalysis/AnalysisTrigger/AnalysisTriggerAlgs
    • Simulation/Digitization
    • Trigger/TrigAlgorithms/TrigL2MuonSA
    • Trigger/TrigSteer/L1Decoder
    • Trigger/TrigT1/L1Topo/L1TopoSimulation
    • Trigger/TrigT1/TrigT1CTMonitoring
    • Trigger/TrigT1/TrigT1CTP
    • Trigger/TrigT1/TrigT1ResultByteStream
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerJobOpts
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @jchapman ,@rosati ,@vmartin ,@okumura ,@fwinkl ,@wiedenma ,@cmorenom ,@bernius ,@asonay ,@jojungge ,@afaulkne ,@sutt ,@dzanzi ,@wleight ,@kwhalen ,@orlando ,@tamartin ,@hrussell ,@rbielski as watchers

  • :white_check_mark: CI Result SUCCESS (hash f9464c9b)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 31026]

  • mentioned in commit 158f7b6d

  • Please register or sign in to reply
    Loading