ATLASRECTS-5657 : Migrate egammaMVACalib package, i.e the MT compliant egamma MVA calibration to be dual use.

Migrate egammaMVACalib package, i.e the MT compliant egamma MVA calibration to be dual use.

This MR targets migrating the new package , but not yet removing the legacy egammaMVACalibAnalysis or any other substantial code changes .

Ideally, given the new AsgService should be like 1-1 , but there is always a chance of missing some detail ...

Pinging @turra , @krumnack

This merge request affects 5 packages:

• PhysicsAnalysis/Interfaces/EgammaAnalysisInterfaces
• Reconstruction/egamma/egammaAlgs
• Reconstruction/egamma/egammaInterfaces
• Reconstruction/egamma/egammaMVACalib
• Reconstruction/egamma/egammaTools

Affected files list will not be printed in this case

Adding @goetz ,@akraszna as watchers

added Analysis Egamma Reconstruction master review-pending-level-1 labels

changed the description

CI Result SUCCESS (hash 2d95f05f)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30723]

changed the description

Hi,
Maybe a Level-2 shifter can take a look as well?
Everything looks fine to me, but I'm not sure if maybe some other changes are necessary as well...
Cheers,
Francisco (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

Hi @christos,

You will need to add dictionaries for all your tool and service implementations that you want to be able to use within AnalysisBase.

Cheers, Nils

I have this

 <lcgdict>
   <class name="egammaMVACalibTool" />
   <class name="egammaMVASvc" />
 </lcgdict>

and Dict

 #include "egammaMVACalib/egammaMVACalibTool.h"
 #include "egammaMVACalib/egammaMVASvc.h"

and

atlas_add_dictionary( egammaMVACalibDict
	egammaMVACalib/egammaMVACalibDict.h
	egammaMVACalib/selection.xml
	LINK_LIBRARIES egammaMVACalibLib )

similar to EgammaAnalysisInterfaces (move from "Reco" egammaInterfaces)

  <class name="IegammaMVACalibTool" /> 
  <class name="IegammaMVASvc" /> 

which one I miss? At least at 0-th level ...

No that's fine then. I missed those.

@fsili Any file or a part of code, in particular, you want me to look at??

Cheers, Abhishek

resolved all threads

Looks good to me. Approving.

Cheers, Abhishek [L2]

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit ace94e63

changed title from Migrate egammaMVACalib package, i.e the MT compliant egamma MVA calibration to be dual use. to ATLASRECTS-5657 : Migrate egammaMVACalib package, i.e the MT compliant egamma MVA calibration to be dual use.

added sweep:ignore label