Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 160
    • Merge requests 160
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !42031

Fix for ALFA_SimHitsTestTool (ATLASSIM-5034)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged John Derek Chapman requested to merge jchapman/athena:ATLASSIM-5034_21.0 into 21.0 Mar 26, 2021
  • Overview 7
  • Commits 1
  • Pipelines 3
  • Changes 2

ALFA_SensitiveDetector can make hits with plate==100 for GVS volumes. Usually 0<plate<10. The hit plotting code in ALFA_SimHitsTestTool assumes a maximum value of 10 when it uses plate as the index to arrays, so when a hit with plate==100 is processed this ends up well outside the array and corrupts the stack. The fix is to put the GVS hits into a separate histogram, skipping the stage where they are used as the index to an array.

Thanks to @ssnyder for finding the issue.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ATLASSIM-5034_21.0