eflowRec: Fix memory `leak'

eflowTrackClusterLink was maintaining a pool of objects, looked up by cluster and track pointers. But these were never cleared, so these objects built up over the entire run of the reconstruction.

Changed to use a SlotSpecificObj that gets cleared after an event is finished. Also a number of other minor cleanups.

This merge request affects 1 package:

• Reconstruction/eflowRec

This merge request affects 9 files:

• Reconstruction/eflowRec/eflowRec/eflowCellIntegrator.h
• Reconstruction/eflowRec/eflowRec/eflowLayerIntegrator.h
• Reconstruction/eflowRec/eflowRec/eflowLookupExp.h
• Reconstruction/eflowRec/eflowRec/eflowTrackClusterLink.h
• Reconstruction/eflowRec/src/PFCellLevelSubtractionTool.cxx
• Reconstruction/eflowRec/src/PFRecoverSplitShowersTool.cxx
• Reconstruction/eflowRec/src/eflowLayerIntegrator.cxx
• Reconstruction/eflowRec/src/eflowLookupExp.cxx
• Reconstruction/eflowRec/src/eflowTrackClusterLink.cxx

Adding @goetz ,@mhodgkin as watchers

added JetEtmiss Reconstruction master review-pending-level-1 labels

CI Result SUCCESS (hash 9caeb20e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30750]

Hello,
I'm passing this MR to a L2 shifter. I'm not entirely sure if everything's right when it comes to memory management...
Thank you,
Cheers, Francisco (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

MR looks fine. Approving.

Cheers, Abhishek [L2]

added review-approved label and removed review-pending-level-2 label

resolved all threads

mentioned in commit e990086a

merged

added sweep:ignore label