Convert surface normal to return by value, no need for allocation. Tidy up Boundary Surface implementations

Convert surface normal to return by value, no need for allocation. Tidy up Boundary Surface implementations

Mentioning @sroe

This merge request affects 2 packages:

• Tracking/TrkDetDescr/TrkSurfaces
• Tracking/TrkDetDescr/TrkVolumes

Affected files list will not be printed in this case

Adding @amorley as watcher

added Tracking master review-pending-level-1 labels

added 1 commit

• 592083ac - put back accidentally removed virtual specifiers

Compare with previous version

This merge request affects 2 packages:

• Tracking/TrkDetDescr/TrkSurfaces
• Tracking/TrkDetDescr/TrkVolumes

Affected files list will not be printed in this case

Adding @amorley as watcher

CI Result FAILURE (hash 592083ac)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30794]

CI Result FAILURE (hash d9f02655)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30793]

added 1 commit

• d38fe91b - Chi2 fix compilation warnings and fabs --> std::abs

Compare with previous version

WARNING: big files (>100K) are found in the changeset

288K in file Tracking/TrkFitter/TrkGlobalChi2Fitter/src/GlobalChi2Fitter.cxx

This merge request affects 3 packages:

• Tracking/TrkDetDescr/TrkSurfaces
• Tracking/TrkDetDescr/TrkVolumes
• Tracking/TrkFitter/TrkGlobalChi2Fitter

Affected files list will not be printed in this case

Adding @amorley as watcher

added 1 commit

• cc3a6e7a - Chi2 fix compilation warnings and fabs --> std::abs

Compare with previous version

WARNING: big files (>100K) are found in the changeset

296K in file Tracking/TrkFitter/TrkGlobalChi2Fitter/src/GlobalChi2Fitter.cxx

This merge request affects 3 packages:

• Tracking/TrkDetDescr/TrkSurfaces
• Tracking/TrkDetDescr/TrkVolumes
• Tracking/TrkFitter/TrkGlobalChi2Fitter

Affected files list will not be printed in this case

Adding @amorley as watcher

CI Result SUCCESS (hash d38fe91b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30803]

CI Result SUCCESS (hash cc3a6e7a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30804]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit cb4b8497

added sweep:ignore label