Skip to content

Fixed case when the no combination is passed by the ComboHypoTool

Tomasz Bold requested to merge tbold/athena:reject-when-all-combinations-fail into master

This MR fixes issue reported in ATR-22980 In the essence, when no combinations passed a combo hypo tool selection the: updateLegDecisionsMap was malfunctioning. An example:

...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG Found two Electrons with mass 24758.7
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG Combination failed mass cut: 24758.7 not in [ 'LowerMassElectronClusterCut':1000.00, 'UpperMassElectronClusterCut':1000.10]
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG End of Tool  -----
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG ComboHypoToolBase: Passing elements are:
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg000_HLT_e5_lhtight_e9_etcut_Jpsiee_L1JPSI-1M5-EM7 ID#86013316 with 1 elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG        HLTNav_IMEmptyEgammaSeq5_Electron , idx: 1
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg001_HLT_e5_lhtight_e9_etcut_Jpsiee_L1JPSI-1M5-EM7 ID#490800720 with 3 elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG        HLTNav_IMEmptyEgammaSeq5_Electron , idx: 0
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG        HLTNav_IMEmptyEgammaSeq5_Electron , idx: 1
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG        HLTNav_IMEmptyEgammaSeq5_Electron , idx: 2
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg000_HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12 ID#805549953 with 1 elements << one element even though the combination was rejected
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG        HLTNav_IMEmptyEgammaSeq5_Electron , idx: 1
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg001_HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12 ID#1608952084 with 1 elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG        HLTNav_IMEmptyEgammaSeq5_Electron , idx: 0



vs after the fix:


...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG Found two Electrons with mass 24758.7
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG Combination failed mass cut: 24758.7 not in [ 'LowerMassElectronClusterCut':1000.00, 'UpperMassElectronClusterCut':1000.10]
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG Combinations rejected, removing respective IDs
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  Removed 805549953
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  Removed 1608952084
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG End of Tool  -----
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG ComboHypoToolBase: Passing elements are:
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg000_HLT_e5_lhtight_e9_etcut_Jpsiee_L1JPSI-1M5-EM7 ID#86013316 with 0 elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg001_HLT_e5_lhtight_e9_etcut_Jpsiee_L1JPSI-1M5-EM7 ID#490800720 with 0 elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg000_HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12 ID#805549953 with 0 elements  <<< zero elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg001_HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12 ID#1608952084 with 0 elements <<< also here

I addition small cleanups of variable names/indents/typos was made.

Merge request reports