Fixed case when the no combination is passed by the ComboHypoTool

This MR fixes issue reported in ATR-22980 In the essence, when no combinations passed a combo hypo tool selection the: updateLegDecisionsMap was malfunctioning. An example:

...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG Found two Electrons with mass 24758.7
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG Combination failed mass cut: 24758.7 not in [ 'LowerMassElectronClusterCut':1000.00, 'UpperMassElectronClusterCut':1000.10]
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG End of Tool  -----
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG ComboHypoToolBase: Passing elements are:
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg000_HLT_e5_lhtight_e9_etcut_Jpsiee_L1JPSI-1M5-EM7 ID#86013316 with 1 elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG        HLTNav_IMEmptyEgammaSeq5_Electron , idx: 1
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg001_HLT_e5_lhtight_e9_etcut_Jpsiee_L1JPSI-1M5-EM7 ID#490800720 with 3 elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG        HLTNav_IMEmptyEgammaSeq5_Electron , idx: 0
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG        HLTNav_IMEmptyEgammaSeq5_Electron , idx: 1
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG        HLTNav_IMEmptyEgammaSeq5_Electron , idx: 2
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg000_HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12 ID#805549953 with 1 elements << one element even though the combination was rejected
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG        HLTNav_IMEmptyEgammaSeq5_Electron , idx: 1
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg001_HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12 ID#1608952084 with 1 elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG        HLTNav_IMEmptyEgammaSeq5_Electron , idx: 0



vs after the fix:


...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG Found two Electrons with mass 24758.7
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG Combination failed mass cut: 24758.7 not in [ 'LowerMassElectronClusterCut':1000.00, 'UpperMassElectronClusterCut':1000.10]
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG Combinations rejected, removing respective IDs
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  Removed 805549953
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  Removed 1608952084
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG End of Tool  -----
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG ComboHypoToolBase: Passing elements are:
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg000_HLT_e5_lhtight_e9_etcut_Jpsiee_L1JPSI-1M5-EM7 ID#86013316 with 0 elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg001_HLT_e5_lhtight_e9_etcut_Jpsiee_L1JPSI-1M5-EM7 ID#490800720 with 0 elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg000_HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12 ID#805549953 with 0 elements  <<< zero elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg001_HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12 ID#1608952084 with 0 elements <<< also here

I addition small cleanups of variable names/indents/typos was made.

This merge request affects 3 packages:

• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest

Affected files list will not be printed in this case

Adding @tamartin ,@vmartin ,@okumura as watchers

added Trigger changes-trigger-counts master review-pending-level-1 labels

Thanks @tbold

Do we understand here

...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg000_HLT_e5_lhtight_e9_etcut_Jpsiee_L1JPSI-1M5-EM7 ID#86013316 with 0 elements
...HLT_e5_lhtight_e14_etcut_Jpsiee_L1JPSI-1M5-EM12   0   0   DEBUG  --- leg001_HLT_e5_lhtight_e9_etcut_Jpsiee_L1JPSI-1M5-EM7 ID#490800720 with 0 elements

why the e14 chain ComboHypoTool is printing information about the e9 chain?

CI Result FAILURE (hash c001ee00)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30895]

Hi, There is an error in the Trigger_Athena_MC-test, reporting from the logfile:

chainComp ERROR    Trigger counts differ from the reference. If the above differences are intended, update the reference

and

2021-03-30T132818 CEST TrigValSteering INFO     Test trigAna_RDOtoRDOTrig_v1Dev_build finished with code 1 because the following required steps failed: ['CountRefComp']

Could you please check that?

Thanks, Marianna

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 63aa03aa - Fixed ref change

Compare with previous version

added 185 commits

• 63aa03aa...d2e7ecf1 - 184 commits from branch atlas:master
• 5a7bbca0 - Resolved conflict

Compare with previous version

This merge request affects 3 packages:

• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest

Affected files list will not be printed in this case

Adding @tamartin ,@vmartin ,@okumura as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 5a7bbca0)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 31004]

Hello, the Trigger_athena_MC-test is still failing (trigger counts differ from the reference), please have a look into that. Thanks, Pienpen(L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 44cbe4e8 - Ref fixed

Compare with previous version

This merge request affects 3 packages:

• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest

Affected files list will not be printed in this case

Adding @tamartin ,@vmartin ,@okumura as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 44cbe4e8)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 31043]

resolved all threads

All threads have been resolved, CI successful. Approving... Lino (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit ab32a22f

added sweep:ignore label