Skip to content
Snippets Groups Projects

Trk Surface bundle together the "optional" Transforms related payload

Merged Trk Surface bundle together the "optional" Transforms related payload
ATLAS-EGamma/athena:Surface_gather_member into master
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:Surface_gather_member into master

Trk Surface. Modify the "optional" transforms related payload.

This is present/needed when the surface is constructed without a detector element, when the surface is constucted with a det element these are not set and relevant calls are delegated to the detector element.

This has the implications that transform, center, normal are set and used together, at least in new MT mode where we do not have mutable caches etc.

This MR bundles them in one struct and the surface has one unique pointer to the struct rather than 3 individual ones.

This should simplify the code logic and reduce the overall number of allocations e.g instead of 3 make_unique one after the other we should have one.

Mentioning @amorley and @sroe

Edited by Christos Anastopoulos

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply