Combine LArHVCondAlg and LArHVScaleCorrAlg into one cond-algo
Incorporate the functionality of LArHVScaleCorrAlg (formerly known as LArHVScaleCorrTool) into LArHVCondAlg. This way we don't need to store the voltages-per-cell in the ConditionsStore. Saves some 50MBytes on q431.
Because of the different code-path, some of the correction factors end up slighlty differently than before (relative diff about 10E-5). No visible difference in the q431 tests.
cc @pavol and @ssnyder with whom I discussed this change before.
Merge request reports
Activity
This merge request affects 4 packages:
- LArCalorimeter/LArCalibUtils
- LArCalorimeter/LArExample/LArConditionsCommon
- LArCalorimeter/LArRecConditions
- LArCalorimeter/LArRecUtils
Affected files list will not be printed in this case
Adding @pavol as watcher
added JetEtmiss LAr master review-pending-level-1 labels
CI Result SUCCESS (hash 78ba757d)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 31249]added review-pending-expert label and removed review-pending-level-1 label
added review-approved label
removed review-pending-expert label
mentioned in commit 3d355b42
added sweep:ignore label
Just for future reference, this along w/ !42146 (merged) (which was included in
2021-03-31T2101
) improved the memory slope in data18RAWtoALL
SPOT reconstruction test job w/--threads=1
quite a bit:Thanks a lot @wlampl.
mentioned in merge request !53183 (merged)