Skip to content
Snippets Groups Projects

Combine LArHVCondAlg and LArHVScaleCorrAlg into one cond-algo

Merged Walter Lampl requested to merge wlampl/athena:LArHVCombinedAlgs1 into master

Incorporate the functionality of LArHVScaleCorrAlg (formerly known as LArHVScaleCorrTool) into LArHVCondAlg. This way we don't need to store the voltages-per-cell in the ConditionsStore. Saves some 50MBytes on q431.

Because of the different code-path, some of the correction factors end up slighlty differently than before (relative diff about 10E-5). No visible difference in the q431 tests.

cc @pavol and @ssnyder with whom I discussed this change before.

Merge request reports

Pipeline #2463879 passed

Pipeline passed for 78ba757d on wlampl:LArHVCombinedAlgs1

Approval is optional
Ready to merge by members who can write to the target branch.

Merge details

  • 1 commit and 1 merge commit will be added to main (squashes 17 commits).
  • Source branch will be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading