Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 167
    • Merge requests 167
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !42411

add support for ToolHandleArray to dual-use C++ configurables, rework handling subtools in AsgComponentConfig

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nils Erik Krumnack requested to merge krumnack/athena:tool_array_config into master Apr 08, 2021
  • Overview 4
  • Commits 2
  • Pipelines 1
  • Changes 7

This is part 1 of a request by @delsart to support configuring ToolHandleArray properties in dual-use code. Part 2 will be supporting it in the dual-use python configurables as well (in a separate MR).

For actually implementing this, I had to restructure AsgComponentConfig quite a bit. Originally I thought this would be easy enough to add to the existing logic, but it turns out it is a lot easier if each subtool is internally represented by an AsgToolConfig object instead.

cc @khoo @wbalunas @akraszna @sawyer @jroloff @jbossios

Edited Apr 08, 2021 by Nils Erik Krumnack
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tool_array_config