Skip to content
Snippets Groups Projects

MdtCalibT0 - remove mutable data-members & package reformatting

Merged MdtCalibT0 - remove mutable data-members & package reformatting
(removed):ATLASRECTS-6177 into master
Merged Johannes Junggeburth requested to merge (removed):ATLASRECTS-6177 into master

Hi,

although the changes in this MR look huge at the first glance, the essential ones are quite minor in the MdtRelativeTubeT0 where I removed the mutable data-member and declared the class methods as non-const. The rest of the changes are reindentation of the package for better readability in the future.

Cheers,

Johannes

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    This merge request affects 1 package:

    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0

    This merge request affects 29 files:

    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/ADCMTHistos.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/HistogramId.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/MTT0PatternRecognition.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/MTTmaxPatternRecognition.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/ReflexHeaders.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/T0CalibrationClassic.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/T0CalibrationMT.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/T0CalibrationOutput.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/T0MTHistos.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/T0MTSettings.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/T0MTSettingsT0.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/T0MTSettingsTMax.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/VariableBinwidthHistogram.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/MdtCalibT0/VariableBinwidthHistogramBin.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/doc/packagedoc.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/exe/T0Fit.cxx
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/ADCMTHistos.cxx
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/HistogramId.cxx
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/MTT0PatternRecognition.cxx
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/MTTmaxPatternRecognition.cxx
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/MdtRelativeTubeT0.cxx
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/MdtRelativeTubeT0.h
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/T0CalibrationClassic.cxx
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/T0CalibrationMT.cxx
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/T0MTHistos.cxx
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/T0MTSettings.cxx
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/T0MTSettingsT0.cxx
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/T0MTSettingsTMax.cxx
    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibT0/src/VariableBinwidthHistogram.cxx

    Adding @rosati ,@wleight ,@jojungge as watchers

  • ATLAS Robot added MuonSpectrometer master review-pending-level-1 labels

    added MuonSpectrometer master review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    :white_check_mark: CI Result SUCCESS (hash 28d10cf2)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 31387]

  • Damian Gil added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Johannes Elmsheuser merged

    merged

  • Johannes Elmsheuser mentioned in commit 08bafe3e

    mentioned in commit 08bafe3e

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

Please register or sign in to reply