Skip to content

First attempt to add beamspot reweighting for muon physval histograms

James Ferrando requested to merge jferrand/athena:master-muon-reweight into master

In this MR I began to add beamspot weighting functionality to the muon physval code. @goblirsc this seems to also affect some tracking validation pacakges.

I have some questions and comments for MCP conveners and validation contact: @atsiamis @mvanadia @gartoni

  1. do the updates generally look correct to you?
  2. In my tests all distributions I tried adjusting seemed to include the weights properly apart from the pt distributions (seemed to stay with weight 1), can you spot a mistake there?
  3. I didn't know how to deal with some distributions which seem to be e.g. TH1s filled with a weight per event already and have put comments in the code need a few examples, any idea on what is a sensible way to weight those?
  4. I left all trigger-related variables unchanged since they aren't part of physval, it may be worth flagging this for the mu trigger people.

tagging also @dhayden @miochoa

Edited by James Ferrando

Merge request reports