Skip to content

Updates to SCT_FrontEnd

Nicholas Styles requested to merge nstyles/athena:master-SCT_FrontEndUpdates into master

A few updates to SCT_FrontEnd which were discovered during development of ITkStrip digitization, but are useful in general for SCT too.

  • Use SiCellId rather than Identifier in doClustering to avoid a conversion Identifier->SiCellId when calling find(), and also avoid range issues over rows for ITkStrips

  • Pass the number of strips on an element in the various method interfaces. Previously, inconsistencies between strip_max and m_strip_max caused an invalid_write for ITkStrips and noise being added to non-existent channels (issues not present for SCT only because all modules have the same number of strips). The solution allows the number of strips to be retrieved just once per element (in process method), and used consistently everywhere.

FYI @jchapman @csebasti @tadej @hhayward

Merge request reports