Skip to content

conf2toConfigurable: make public tools public (add to ToolSvc)

Rafal Bielski requested to merge rbielski/athena:conf2toConfigurable-pubtool into master

Fix a bug where public tools added by conf2toConfigurable were not actually public because they were not added to the ToolSvc. This led to the following errors:

  File "/atlas/datafiles/rbielski/ATR-22872-22.0.28/build/x86_64-centos7-gcc8-opt/python/AthenaConfiguration/ComponentAccumulator.py", line 1133, in conf2toConfigurable
    __areSettingsSame( existingConfigurable, comp )
  File "/atlas/datafiles/rbielski/ATR-22872-22.0.28/build/x86_64-centos7-gcc8-opt/python/AthenaConfiguration/ComponentAccumulator.py", line 1065, in __areSettingsSame
    alreadySetProperties[pname].append(klass( pubtoolname ))
  File "/sw/atlas/AthenaExternals/22.0.28/InstallArea/x86_64-centos7-gcc8-opt/python/GaudiKernel/GaudiHandles.py", line 200, in append
    self.__class__.__name__))
TypeError: Can not append IOVDbMetaDataTool (Private AlgTool) to a PublicToolHandleArray

as encountered in ATR-22872.

cc @wlampl, @tbold

Merge request reports