Skip to content

EDMVersion flag: change default to -1, remove from TriggerFlags

Rafal Bielski requested to merge rbielski/athena:edmversion-default into master

The following changes are made:

  • Remove TriggerFlags.EDMVersion which has been deprecated for a few months. All clients are already using ConfigFlags.Trigger.EDMVersion.
  • Change default value of ConfigFlags.Trigger.EDMVersion from 3 to intentionally invalid value -1 as discussed in ATR-22856.
  • Adapt a few places in TriggerJobOpts and TrigEDMConfig which would treat -1 same as 1 or 2 (e.g. if they checked EDMVersion <= 2) to check for 1 or 2 exactly, and throw an exception if unhandled value is provided. The few "EDMVersion < 3" cases in TrigMonitoring are not modified, as the logic still holds for them and they are not crucial/central enough to implement extensive sanity checks on central flags.

Closes ATR-22856

Merge request reports