Skip to content
Snippets Groups Projects

Remove RPC cabling service

Merged Nicolas Koehler requested to merge nkoehler/athena:rpcCabDel into master

Hi,

all clients in athena have been migrated to use the RpcCablingCondData access for thread safe cabling conditions access. Now, we can remove the previous service from the repository.

Best, Nico

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request affects 11 packages:

    • MuonSpectrometer/MuonCablings/MuonCablingServers
    • MuonSpectrometer/MuonCablings/MuonRPC_Cabling
    • MuonSpectrometer/MuonCablings/RPCcablingInterface
    • MuonSpectrometer/MuonCnv/MuonByteStream
    • MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
    • MuonSpectrometer/MuonCnv/MuonJiveXML
    • MuonSpectrometer/MuonCnv/MuonRPC_CnvTools
    • MuonSpectrometer/MuonConditions/MuonCondCabling/RPC_CondCabling
    • MuonSpectrometer/MuonDetDescr/MuonRegionSelector
    • MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/RpcRawDataMonitoring
    • Trigger/TrigT1/TrigT1RPClogic

    Affected files list will not be printed in this case

    Adding @sutt ,@rosati ,@wleight ,@afaulkne ,@jojungge as watchers

  • Nicolas Koehler mentioned in merge request !33329 (merged)

    mentioned in merge request !33329 (merged)

  • :negative_squared_cross_mark: CI Result FAILURE (hash 1f30af7e)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 5, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 32054]

  • added 1 commit

    Compare with previous version

  • This merge request affects 11 packages:

    • MuonSpectrometer/MuonCablings/MuonCablingServers
    • MuonSpectrometer/MuonCablings/MuonRPC_Cabling
    • MuonSpectrometer/MuonCablings/RPCcablingInterface
    • MuonSpectrometer/MuonCnv/MuonByteStream
    • MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
    • MuonSpectrometer/MuonCnv/MuonJiveXML
    • MuonSpectrometer/MuonCnv/MuonRPC_CnvTools
    • MuonSpectrometer/MuonConditions/MuonCondCabling/RPC_CondCabling
    • MuonSpectrometer/MuonDetDescr/MuonRegionSelector
    • MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/RpcRawDataMonitoring
    • Trigger/TrigT1/TrigT1RPClogic

    Affected files list will not be printed in this case

    Adding @sutt ,@rosati ,@wleight ,@afaulkne ,@jojungge as watchers

  • added 1 commit

    Compare with previous version

  • This merge request affects 12 packages:

    • MuonSpectrometer/MuonCablings/MuonCablingServers
    • MuonSpectrometer/MuonCablings/MuonRPC_Cabling
    • MuonSpectrometer/MuonCablings/RPCcablingInterface
    • MuonSpectrometer/MuonCnv/MuonByteStream
    • MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
    • MuonSpectrometer/MuonCnv/MuonJiveXML
    • MuonSpectrometer/MuonCnv/MuonRPC_CnvTools
    • MuonSpectrometer/MuonConditions/MuonCondCabling/RPC_CondCabling
    • MuonSpectrometer/MuonDetDescr/MuonRegionSelector
    • MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/RpcRawDataMonitoring
    • Trigger/TrigT1/TrigT1RPClogic
    • Trigger/TrigT1/TrigT1RPCsteering

    Affected files list will not be printed in this case

    Adding @sutt ,@rosati ,@wleight ,@afaulkne ,@jojungge as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash 74c7cca0)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 4, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 32082]

  • :negative_squared_cross_mark: CI Result FAILURE (hash 17fe8908)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 32083]

  • added 1 commit

    Compare with previous version

  • This merge request affects 12 packages:

    • MuonSpectrometer/MuonCablings/MuonCablingServers
    • MuonSpectrometer/MuonCablings/MuonRPC_Cabling
    • MuonSpectrometer/MuonCablings/RPCcablingInterface
    • MuonSpectrometer/MuonCnv/MuonByteStream
    • MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
    • MuonSpectrometer/MuonCnv/MuonJiveXML
    • MuonSpectrometer/MuonCnv/MuonRPC_CnvTools
    • MuonSpectrometer/MuonConditions/MuonCondCabling/RPC_CondCabling
    • MuonSpectrometer/MuonDetDescr/MuonRegionSelector
    • MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/RpcRawDataMonitoring
    • Trigger/TrigT1/TrigT1RPClogic
    • Trigger/TrigT1/TrigT1RPCsteering

    Affected files list will not be printed in this case

    Adding @sutt ,@rosati ,@wleight ,@afaulkne ,@jojungge as watchers

  • :white_check_mark: CI Result SUCCESS (hash ea3491f5)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 32089]

  • CI is successful now, but it looks like the full-build was added only afterwards? Should we go for a retry here to be sure?

  • Hi,

    no if the test succeeds this way, I am fine with it.

  • Great, approving then.

  • Nicolas Koehler added 43 commits

    added 43 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading