jet hypo - use Pt rather than Et as a threshold variable.

For the simple variable, the et thresholds have been switched variable has been switched from et to pt.

For the dijet scenario, either 'et' or 'pt' may appear in the scenario string.

The HT scenario has not been changed. This will be changed once othercurrently ongoing work has been completed.

The fbdj scenarios remain with et cuts. pt cuts may be enabled later.

Small differences in the chain counts were observed.

Add support for pt cuts: TrigHLTJetHypo/python/ConditionDefaults.py python/FastReductionAlgToolFactory.py TrigHLTJetHypo/src/PtConditionMT.cxx, h TrigHLTJetHypo/src/TrigJetConditionConfig_pt.cxx, h TrigHLTJetHypo/src/components/TrigHLTJetHypo_entries.cxx

allow pt cuts for the dijet scenario: TrigHLTJetHypo/python/scenario_dijet.py

witch to using pt as a threshold variable for the simple scenario: TrigHLTJetHypo/python/scenario_simple.py

update menu items: HLTMenuConfig/python/HLTMenuConfig/Menu/LS2_v1.py HLTMenuConfig/Menu/SignatureDicts.py

update Trigger Art reference files: TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref TriggerTest/share/ref_data_v1Dev_build.ref

ATR-19908

@jbossio @valentem @peter

changed the description

added 132 commits

• 7fd74c0e...3069427e - 131 commits from branch atlas:master
• 12e4d6de - Merge remote-tracking branch 'upstream/master' into master-19908-1

Compare with previous version

added 1 commit

• 124dc6b2 - jet hypo - update Trig ART test reference files after move to using pt as the threshold variable

Compare with previous version

marked this merge request as ready

added 92 commits

• 124dc6b2...95e10306 - 91 commits from branch atlas:master
• 46ebe9a9 - Merge remote-tracking branch 'upstream/master' into master-19908-1

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@dzanzi ,@iriu ,@vmartin ,@okumura ,@carquin ,@ademaria ,@bernius ,@hrussell ,@malconad ,@peter ,@jbossios ,@valentem as watchers

added JetEtmiss Trigger TriggerJet TriggerMenu changes-trigger-counts master review-pending-level-1 labels

@rbielski

Hi Rafal,

I am fhaving a problem with the Trigger ART tests. How should dI interpret the following:

ERROR ================================================== ERROR The following 3 tests failed: ERROR test_trigAna_RDOtoRDOTrig_v1Dev_build.py ERROR test_trigP1_v1Dev_build.py ERROR test_trig_data_v1Dev_build.py ERROR ================================================== INFO ================================================== INFO Printing output of failed CountRefComp for test_trigAna_RDOtoRDOTrig_v1Dev_build.py usage: chainComp.py [options] inputFile chainComp.py: error: unrecognized arguments: --patch

Thanks for the great explanation.

CI Result FAILURE (hash 46ebe9a9)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 32618]

added 1 commit

• ffab4f93 - jet hypo - Trigger ART ref file update

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@dzanzi ,@iriu ,@vmartin ,@okumura ,@carquin ,@ademaria ,@bernius ,@hrussell ,@malconad ,@peter ,@jbossios ,@valentem as watchers

CI Result SUCCESS (hash ffab4f93)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 32663]

Can the unresolved thread be resolved? Then we can go ahead with review. -Mike (L1)

resolved all threads

resolved all threads

resolved all threads

Well done GitLab for handling three people resolving the thread simultaneously

Well the probability of even two simultaneous updates is zero. Did ypu mean pseudo-simultaneous?

Well yeah, I meant that the backend accepted the three subsequent requests for the same thing in short succession :) Anyway, the thread is most definitely resolved and the review can proceed