TrigBSExtraction: simplify configuration and code cleanup

Merge the EFResultKey and HLTResultKey properties as they serve the same purpose (final result of EF/HLT processing).

Fix a bug in the equalize option. This should only be set to true if reading data with an L2 and EF result (Run-1 data). In all other cases this is not necessary (but also did not cause any harm as the L2 navigation would have been empty).

Also delete commented code and unused ResultKey properties in TrigBStoxAODTool.

This merge request affects 2 packages:

• Trigger/TrigEvent/TrigBSExtraction
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

added Trigger master review-pending-level-1 labels

CI Result FAILURE (hash c29634d2)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 32923]

added review-user-action-required label and removed review-pending-level-1 label

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigEvent/TrigBSExtraction
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash c29634d2)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33519]

added review-user-action-required label and removed review-pending-level-1 label

Putting back the review-user-action-required label as no action had been taken since it was first introduced. Cheers Lino (L1)

marked this merge request as draft

removed review-user-action-required label

added 1569 commits

• c29634d2...df671a77 - 1568 commits from branch atlas:master
• 9b9a9f07 - TrigBSExtraction: further code cleanup

Compare with previous version

added 467 commits

• 9b9a9f07...7f818e8d - 466 commits from branch atlas:master
• 1e25a23b - TrigBSExtraction: further code cleanup

Compare with previous version

added 1 commit

• e11ad432 - TrigBSExtraction: simplify configuration and code cleanup

Compare with previous version

marked this merge request as ready

changed title from Draft: TrigBSExtraction: further code cleanup to TrigBSExtraction: simplify configuration and code cleanup

This merge request affects 2 packages:

• Trigger/TrigEvent/TrigBSExtraction
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

added review-pending-level-1 label

CI Result SUCCESS (hash e11ad432)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 35006]