Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 167
    • Merge requests 167
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !43232

Update FTag Physval code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Judith Hofer requested to merge juhofer/athena:ftag-physval_master into master May 05, 2021
  • Overview 4
  • Commits 6
  • Pipelines 1
  • Changes 5

Hi,

this MR does several small updates to the FTag Physval code.

The comparison plots with and without the code changes show perfect agreement, except for the IP3D d0 and z0 significances, where I changed the range: https://juhofer.web.cern.ch/juhofer/PHYSVAL/test_plots/test_MR_2021-05-04/

The commit juhofer/athena@81404070 is the quick fix for the issue reported here: AFT-555.
The code now runs on the Sherpa sample without crashing (histograms produced and compared to themselves are here: https://juhofer.web.cern.ch/juhofer/PHYSVAL/test_plots/test_MR_2021-05-04_Sherpa_sample_test/plots/)

The code was also tested on a private DAOD_PHYSVAL sample, the plots can be found here (histograms are compared to themselves again): https://juhofer.web.cern.ch/juhofer/PHYSVAL/test_plots/test_MR_2021-05-04_on_DAOD_PHYSVAL/plots/

Best,
Judith

Edited May 05, 2021 by Judith Hofer
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ftag-physval_master