Skip to content

Preparation of making eflowRec pass the MT static checker remove mutable.

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:eflowRecCluster_clean_up_mutable into master

Preparation of making eflowRec pass the MT static checker remove mutable.

  • remove mutable.
  • setters can not be const.
  • Use CachedValue for lazy init.
  • And const/non-const overloads.
  • Remove const from un-needed places
  • Add const to needed places.

@mhodgkin and @manthony this still leaves a couple of const_cast [https://acode-browser1.usatlas.bnl.gov/lxr/search?%21v=head&_filestring=eflowRec&_string=const_cast]

my understanding from @mhodgkin is that you do not really const_cast cells from the store this would be problematic, but you own copies in which case I guess you can avoid them ?

Merge request reports