Skip to content

TrigValidation: Enable FPEAuditor by default in Trigger ART tests

Rafal Bielski requested to merge rbielski/athena:trigval-fpeauditor into master

Add an option fpe_auditor in TrigValSteering.ExecStep with default setting to True. The new option modifies the command line arguments to enable the fpeAuditor Modifier where applicable.

"Where applicable" means all athena / athenaHLT jobs using the runHLT_standalone.py job options and all transforms running the Trigger step, i.e. BSRDOtoRAW or RDOtoRDOTrigger.

The explicit addition of the modifier is removed from the few tests which had it, because it's now the default. The option is explicitly disabled in the two "dumpConfig" tests in TrigP1Test as we don't want FPEAuditor in the configuration to be uploaded for P1 operation (we only want to run it in ART).

Additionally, the corresponding message patterns are added in check_log.py to make sure we catch the FPEs and that the Trigger Validation Shifters can report them to developers.

cc @okumura, @vmartin, @smh, @fwinkl, @dzanzi, @hartj

Edited by Rafal Bielski

Merge request reports