Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 183
    • Merge requests 183
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !43616

L1Calo efex thresholds now from the menu, finer granularity tob eta range, and code cleanup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alison Elliot requested to merge afaulkne/athena:master-L1CaloMenu-updates into master May 17, 2021
  • Overview 19
  • Commits 3
  • Pipelines 3
  • Changes 12

Several updates for the L1Calo eFEX bitwise simulation:

-- the thresholds are now taken from the L1Menu, and set the reta rhad and wstot working points in the tob, and EDM.

-- the TOB words in the EDM now use the eta seed as well, meaning they should have the finer granularity from 0.1 to 0.025

-- several bugs fixed: ---- TOB sorting and resizing no longer requires 6 tobs (can have fewer). ---- code requiring TOBs to have a seed was commented out for debugging - and is now reinstated.

-- some deprecated histogram testing code removed

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-L1CaloMenu-updates