Include safety checks and minimum pT cut for jet matching in JetMonitoring

This MR addresses the problem observed in https://its.cern.ch/jira/browse/ATR-23458

• Now we skip jets in jet matching when they have pT < 10 GeV (if it's the nominal jet, every entry is set to -999 and matched=false)
• If the energy or mass of the second jet is 0, the corresponding relative response is set to -999.

@jbossios

marked this merge request as ready

This merge request affects 1 package:

• Reconstruction/Jet/JetMonitoring

This merge request affects 1 file:

• Reconstruction/Jet/JetMonitoring/src/JetMatcherAlg.cxx

Adding @goetz ,@jgeisen as watchers

added DQ JetEtmiss Reconstruction analysis-review-required master review-pending-level-1 labels

CI Result FAILURE (hash ef0e121a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 3, warnings 22
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33839]

Jenkins please retry a build

This merge request affects 1 package:

• Reconstruction/Jet/JetMonitoring

This merge request affects 1 file:

• Reconstruction/Jet/JetMonitoring/src/JetMatcherAlg.cxx

Adding @goetz ,@jgeisen as watchers

CI Result SUCCESS (hash ef0e121a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33847]

Changes look good, CI passed - approving.

Jakub (L1 shifter)

added review-approved label and removed review-pending-level-1 label

added 1 commit

• 4dc07f7f - Use MonitoredCollection better in JetRecAlg

Compare with previous version

This merge request affects 2 packages:

• Reconstruction/Jet/JetMonitoring
• Reconstruction/Jet/JetRec

Affected files list will not be printed in this case

Adding @goetz ,@jgeisen as watchers

added review-pending-level-1 label and removed review-approved label

added 153 commits

• 4dc07f7f...abae87b1 - 152 commits from branch atlas:master
• 5861b198 - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena

Compare with previous version

This merge request affects 2 packages:

• Reconstruction/Jet/JetMonitoring
• Reconstruction/Jet/JetRec

Affected files list will not be printed in this case

Adding @goetz ,@jgeisen as watchers

@jkremer oh no, I'm sorry, I accidentally pulled the newest athena master and pushed to my fork before waiting for the merging. I accidentally included changes for another future MR already here - how can I revert this?

added 1 commit

• c5706018 - Revert changes to JetRecAlg

Compare with previous version

This merge request affects 2 packages:

• Reconstruction/Jet/JetMonitoring
• Reconstruction/Jet/JetRec

Affected files list will not be printed in this case

Adding @goetz ,@jgeisen as watchers

@jkremer OK I reverted the accidental changes now, so everything is the same as when you approved the MR. Let's wait for the CI.

@jgeisen, yeah that's really unfortunate, but I see that everything is back to where it was when the MR was approved, so once the CI passes again it can be re-approved.

Jakub (L1 shifter)

CI Result SUCCESS (hash 5861b198)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33897]