MuidCaloMaterialParam - Use internally unique_ptrs
Hi,
this MR updates the memory management of MuidCaloMaterialParam
such that the calorimeter layers are hold internally by a vector of unique_ptrs instead of raw pointers which allows us to get rid of the unnecessary finalize()
and is part of the interface developments in ATLASRECTS-6350
Cheers, Johannes
Merge request reports
Activity
This merge request affects 1 package:
- Reconstruction/MuonIdentification/MuidCaloScatteringTools
This merge request affects 2 files:
- Reconstruction/MuonIdentification/MuidCaloScatteringTools/MuidCaloScatteringTools/MuidCaloMaterialParam.h
- Reconstruction/MuonIdentification/MuidCaloScatteringTools/src/MuidCaloMaterialParam.cxx
added Reconstruction master review-pending-level-1 labels
CI Result FAILURE (hash e6a773e5)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 34076]This merge request affects 1 package:
- Reconstruction/MuonIdentification/MuidCaloScatteringTools
This merge request affects 3 files:
- Reconstruction/MuonIdentification/MuidCaloScatteringTools/MuidCaloScatteringTools/MuidCaloMaterialParam.h
- Reconstruction/MuonIdentification/MuidCaloScatteringTools/MuidCaloScatteringTools/MuidMaterialEffectsOnTrackProvider.h
- Reconstruction/MuonIdentification/MuidCaloScatteringTools/src/MuidCaloMaterialParam.cxx
CI Result SUCCESS (hash 5e7abf3e)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 34089]added review-approved label and removed review-pending-level-1 label
mentioned in commit 47a74903
added sweep:ignore label