TrackDeposiInCaloTool - Add thread-safety check & refurbishment

Johannes Junggeburthrequested to merge
(removed):refurbish_TrackDepositInCaloTool into master

Hi,

this MR is a thorough refurbishment of the TrackDepositInCaloTool:

  • All while loops have been replaced by ranged for loops.
  • Nested branching in the code in the manner of if(my_condition) has been replaced by if (!my_condition) {continue;} to improve readability of the code and to ease the branching
  • Data dependency on AllCell has been added as the m_caloCellContainer variable was used in few places but actually never set.
  • Usage of smart pointers to get rid of delete statements
  • Added THREAD_SAFETY_CHECKER

Adding: @christos, @jburr

Merge request reports