new L1 Raw/RDO containers for TGC
- Updated BS format in TGC
- Added new L1 Raw/RDO containers (all empty) as preparation of installation of New Sector Logic in TGC
Merge request reports
Activity
mentioned in merge request !38119 (closed)
This merge request affects 5 packages:
- MuonSpectrometer/MuonCnv/MuonEventAthenaPool
- MuonSpectrometer/MuonCnv/MuonEventTPCnv
- MuonSpectrometer/MuonCnv/MuonTGC_CnvTools
- MuonSpectrometer/MuonRDO
- MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonTrigCoinData
Affected files list will not be printed in this case
added MuonSpectrometer Trigger master review-pending-level-1 labels
❎ CI Result FAILURE (hash c51ff76d)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals ✅ ✅ ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ ✅ ✅ required tests ⭕ ✅ ✅ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ ✅ ✅ Full details available on this CI monitor view
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthAnalysis: number of compilation errors 0, warnings 0
✅ DetCommon: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 34223]- Resolved by Adam Edward Barton
It looks like both times the CI ran out of time. May I ask the L2 shifter to confirm?
removed review-pending-level-1 label
added review-pending-level-2 label
Hi @toshi ,
could you please confirm, that the following error in T0 tests is expected:
ERROR Py:diff-root WARNING the following variables exist only in the old file !
ERROR Py:diff-root WARNING - [TgcRdoContainer_p3_TGCRDO]
ERROR Py:diff-root WARNING the following variables exist only in the new file !
ERROR Py:diff-root WARNING - [TgcRdoContainer_p4_TGCRDO]
? Thanks, Pavol [as L2 MR shifter]
Hi @pavol , Thanks for checking. In my local test with RunTier0Tests.py, those ERRORs appear too, although I don't know this is expected when a schema evolution is implemented. Regards, Toshi
Thanks a lot for the clarification, @pavol ! So, could you approve this request even though there would be the ERRORs until a new release is built ? -T
- Resolved by Adam Edward Barton
Quite a lot of changes and new code, but looks to me thet pretty standard, and I do not see any big problems here, so approving.
Pavol [as L2 MR shifter]
added review-approved label and removed review-pending-level-2 label
mentioned in commit c276c24d
added sweep:ignore label
mentioned in merge request !43912 (merged)
This seems to be causing some CI failures. For example: !43912 (merged)
Hi @toshi,
- Overlay references will have to be updated
- This may affect trigger in R21. Have these containers been backported there?
Hi @tadej, all, I'm sorry for the trouble from the CI failures. Would you tell me how to update the references ? For the backward compatibility, the new containers should have same variables, even after some trigger related ones would go to the new "L1" containers. Regards, Toshi
Yes. I think we should revert this MR for now and do the changes step-by-step. Opened a MR here: !43927 (merged)