Skip to content

TrigSerializeCnvSvc: do not overwrite TrigRoiDescriptorCollection

Frank Winklmeier requested to merge fwinkl/athena:roi_overwrite into master

Remove the special case that allowed overwriting TrigRoiDescriptorCollection in StoreGate when reconstructing RAW data. This exception was introduced as part of the ElementLink corruption saga in (ATEAM-734, !43270 (merged)) but does not seem to be needed anymore.

Tested multiple times with q431, 1500 events and 12 threads. I could not trigger the ERROR ... is already in the store ... message that will now appear in case the code tries to overwrite this collection. There is a chance I was just unlucky in which case we should see this in some of the ART tests. We then immediately revert this MR and fix the actual source of the problem.

RC Attention Required in case there is a preference to only merge this after the nightly to be used for the next large scale test.

Heads-up to @mhodgkin and @goetz.

Edited by Frank Winklmeier

Merge request reports