Skip to content

ATLASRECTS-6411 : Fix semantics when we construct the m_associatedSurface from ptr

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:SurfaceHolder_special_impl_for_ptr into master

ATLASRECTS-6411 : Fix semantics when we construct the m_associatedSurface from ptr. Since we do this via .release() we need to always take ownership and never clone

Should be fixing these kind of issues

seudoMeasurementOnTrackCnv_p2_test.exe: /build/atnight/localbuilds/nightlies/Athena/master/athena/AtlasTest/TestTools/TestTools/leakcheck.h:95: Athena_test::Leakcheck::~Leakcheck(): Assertion `m_allocs.empty()' failed.
[97;101;1m post.sh> ERROR: Athena exited abnormally! Exit code: 134 [m
 post.sh> Please check /build/atnight/localbuilds/nightlies/Athena/master/build/build/Athena/Tracking/TrkEventCnv/TrkEventTPCnv/CMakeFiles/unitTestRun/PseudoMeasurementOnTrackCnv_p2_test.log

      Start 1653: TrkEventTPCnv_CompetingRIOsOnTrackCnv_p1_test_ctest
 9/15 Test #1653: TrkEventTPCnv_CompetingRIOsOnTrackCnv_p1_test_ctest .......   Passed    1.45 sec
      Start 1654: TrkEventTPCnv_TrackStateOnSurfaceCnv_p3_test_ctest
10/15 Test #1654: TrkEventTPCnv_TrackStateOnSurfaceCnv_p3_test_ctest ........***Failed    1.28 sec
test1
Leaks!
  0x1b5e340
  0x1b5e4a0
  0x1b5e160
  0x1b5e0e0

Mentioning @sroe, @amete, @ssnyder

PS: I was assuming (blindness I guess) that we do .get and that what I was testing in the Holder unit tests, although in the production code we were and I had retained .release .... 🤦

Edited by Christos Anastopoulos

Merge request reports