Skip to content
Snippets Groups Projects

No ghost tracks on some HLT jet collections

Merged Jonathan Bossio requested to merge jbossios/athena:RemoveGhostMatching4a10Anda10t into master
All threads resolved!

Do not use ghost tracks for chains using:

  • nonPF a10
  • nonPF a10t
  • a10r chains

even on FTF chains (and write to a non-FTF jet container).

ATR-23537

@khoo @valentem

Edited by Jonathan Bossio

Merge request reports

Pipeline #2713262 passed

Pipeline passed for b668b991 on jbossios:RemoveGhostMatching4a10Anda10t

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 3 years ago (Jun 14, 2021 3:41pm UTC)

Merge details

  • Changes merged into master with d568a97f (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 9e38e802 - Explain and ensure to be always consistent

    Compare with previous version

  • Jonathan Bossio changed the description

    changed the description

  • Teng Jian Khoo
  • added 1 commit

    Compare with previous version

  • Teng Jian Khoo resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Jonathan Bossio marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 1 package:

    • Trigger/TriggerCommon/TriggerMenuMT

    This merge request affects 2 files:

    • Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/JetRecoConfiguration.py
    • Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/JetRecoSequences.py

    Adding @sutt ,@hrussell ,@dzanzi ,@bernius as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash fa94e686)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 35222]

  • Let's restart CI to have access to the tabulated test results (they were deleted by error due to the ongoing AFS downsie), as looking through the Jenkins output for test failures is kind of painful -- L1

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • Trigger/TriggerCommon/TriggerMenuMT

    This merge request affects 2 files:

    • Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/JetRecoConfiguration.py
    • Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/JetRecoSequences.py

    Adding @sutt ,@hrussell ,@dzanzi ,@bernius as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash fa94e686)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 35261]

  • added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TriggerCommon/TriggerMenuMT

    This merge request affects 2 files:

    • Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/JetRecoConfiguration.py
    • Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Jet/JetRecoSequences.py

    Adding @sutt ,@hrussell ,@dzanzi ,@bernius as watchers

  • :white_check_mark: CI Result SUCCESS (hash b668b991)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 35286]

  • Changes look fine, the CI is good and all threads have been resolved. Approving. Clara (L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit d568a97f

  • Please register or sign in to reply
    Loading