Skip to content

Don't use full-scan RoIs for RoI-based Partial Event Building

Rafal Bielski requested to merge rbielski/athena:fix-jet-peb into master

RoI-based Partial Event Building only makes sense when "real" RoIs are passed as input, not dummy full-scan RoIs. The LArPEB jet chains were previously misconfigured such that full-scan RoIs were being passed as PEB input. Fix and prevent this issue with the following changes:

  • Print a runtime error if a full-scan RoI is passed as input to RoIPEBInfoWriterTool.
  • Update EventBuildingSequences.py such that full-scan chains which use RoIPEBInfoWriterTool create and use new RoIs based on particles ("features") created in the previous chain step. Record these new RoIs in EDM for consistency.

Also make mergeUsingFeature = True the default for PEB input maker in all chains using RoI-based PEB.

Fixes ATR-23604

Edited by Rafal Bielski

Merge request reports