Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 151
    • Merge requests 151
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !44513

AnalysisTop: Implementing a workaround for ROOT 6.24 bug

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tomas Dado requested to merge tdado/athena:AT-RootBugWorkaround into master Jun 17, 2021
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

This is an update that is needed for AnalysisTop code when custom event savers are used. Without this change, the ROOT dictionary cannot be properly buillt.

It was identified that this is a bug in ROOT: https://github.com/root-project/root/issues/8469

To make it obvious, the weird part here is that the code is already inside top namespace so the additional top:: should be superfluous, but apparently is needed for the ROOT dictionary building.

Fixes ATLASG-1596

Edited Jun 17, 2021 by Tomas Dado
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: AT-RootBugWorkaround