Skip to content
Snippets Groups Projects

Fix preprocessor directives don't get files for the configuration jobs

Merged Fix preprocessor directives don't get files for the configuration jobs
sutt/athena:ci into master
All threads resolved!
Merged Mark Sutton requested to merge sutt/athena:ci into master
All threads resolved!

Some preprocessor directives were not properly included, this fixes them, also doesn't bother to fetch any of the dat files if the job is set up to configure only

Merge request reports

Pipeline #2734114 passed

Stage: external

Pipeline passed for a9a5b7ed on sutt:ci

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 4 years ago (Jun 18, 2021 12:48pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Sutton added 1 commit

    added 1 commit

    • a9a5b7ed - Add dependence on TRIGVALSTEERING_DRY_RUN envoronmant variable

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    This merge request affects 2 packages:

    • Trigger/TrigAnalysis/TrigInDetAnalysisUser
    • Trigger/TrigValidation/TrigInDetValidation

    Affected files list will not be printed in this case

    Adding @sutt ,@hartj ,@okumura ,@vmartin ,@nagano ,@mvozak as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    :white_check_mark: CI Result SUCCESS (hash a9a5b7ed)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 35651]

  • Frank Winklmeier resolved all threads

    resolved all threads

  • D
    Damian Gil @dgil
    Developer

    Discussion finished, CI passed, code looks fine - approving (L1).

  • Damian Gil added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Frank Winklmeier mentioned in commit 119085c5

    mentioned in commit 119085c5

  • Frank Winklmeier merged

    merged

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply